Skip to content

Allow ExprIndicesOfValue to search for the indices of multiple values #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2025
Merged

Allow ExprIndicesOfValue to search for the indices of multiple values #8252

merged 4 commits into from
Nov 11, 2025

Conversation

@UnderscoreTud
Copy link
Member

@UnderscoreTud UnderscoreTud commented Oct 22, 2025

Problem

ExprIndicesOfValue could only search for the indices of one value at a time

Solution

Allow multiple values to be used in the expression

Testing Completed

ExprIndicesOfValue.sk

Supporting Information

Completes: #8133
Related: none

@UnderscoreTud UnderscoreTud requested a review from a team as a code owner October 22, 2025 18:28
@UnderscoreTud UnderscoreTud removed the request for review from a team October 22, 2025 18:28
@UnderscoreTud UnderscoreTud added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 22, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 22, 2025
sovdeeth
sovdeeth requested changes Oct 23, 2025
View reviewed changes
@sovdeeth sovdeeth linked an issue Oct 23, 2025 that may be closed by this pull request
Use list in get value of indice #8133
Open
1 task
@sovdeeth sovdeeth moved this to In Review in 2.13 Releases Oct 23, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Nov 3, 2025
@APickledWalrus APickledWalrus moved this to In Review in 2.14 Releases Nov 3, 2025
@APickledWalrus APickledWalrus changed the base branch from dev/patch to dev/feature November 3, 2025 18:03
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Nov 6, 2025
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 6, 2025
@sovdeeth sovdeeth merged commit 4ddc1af into dev/feature Nov 11, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Nov 11, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Burbulinis Burbulinis Burbulinis approved these changes

@erenkarakal erenkarakal Awaiting requested review from erenkarakal erenkarakal is a code owner automatically assigned from SkriptLang/core-developers

@Absolutionism Absolutionism Awaiting requested review from Absolutionism Absolutionism is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

2.14 Releases
Status: Done - Awaiting Release

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use list in get value of indice

5 participants

@UnderscoreTud @sovdeeth @APickledWalrus @Burbulinis