Copper Golem + Copper Block Support #8244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
Absolutionism
requested review from
Burbulinis and
TheMug06
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
requested changes
Oct 18, 2025
sovdeeth
requested changes
Oct 18, 2025
src/main/java/ch/njol/skript/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
Member
|
Forgot to write this in the last review, but this should all be in the skriptlang package. |
Absolutionism
requested review from
APickledWalrus
and removed request for
a team
sovdeeth
requested changes
Oct 23, 2025
src/main/java/org/skriptlang/skript/bukkit/elements/effects/EffWax.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/elements/expressions/ExprCopperState.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/paperutil/CopperState.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Oct 23, 2025
sovdeeth
approved these changes
Oct 23, 2025
Efnilite
requested changes
Oct 26, 2025
...ain/java/org/skriptlang/skript/bukkit/elements/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
...ain/java/org/skriptlang/skript/bukkit/elements/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/paperutil/CopperState.java
Outdated
Show resolved
Hide resolved
Efnilite
approved these changes
Nov 3, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.14 Releases
skriptlang-automation
bot
added
feature-ready
APickledWalrus
requested changes
Nov 3, 2025
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
Overall this looks good. I have some suggestions about the organization/modularization.
src/main/java/org/skriptlang/skript/bukkit/elements/conditions/CondIsWaxed.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/elements/effects/EffWax.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/elements/effects/EffWax.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/elements/effects/EffWax.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Awaiting Merge
to In Review
in 2.14 Releases
skriptlang-automation
bot
added
feature-ready
# Conflicts: # src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprTextOf.java
APickledWalrus
requested changes
Nov 8, 2025
| public void load(SkriptAddon addon) { | ||
| ExprCopperGolemOxidationTime.register(addon.syntaxRegistry()); | ||
|
|
||
| CopperGolemData.register(); |
Member
There was a problem hiding this comment.
I would override the init method and register this there instead
| if (!(entity instanceof CopperGolem golem)) | ||
| continue; | ||
| long worldTime = golem.getWorld().getGameTime(); | ||
| golem.setOxidizing(Oxidizing.atTime(worldTime + ticks)); |
Member
There was a problem hiding this comment.
Probably need to check for negative values from overflow here
|
|
||
| @Override | ||
| public Class<?> @Nullable [] acceptChange(ChangeMode mode) { | ||
| if (mode == ChangeMode.SET || mode == ChangeMode.RESET) |
skriptlang-automation
bot
removed
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No proper support for setting and getting attributes of copper golems and copper blocks.
Solution
Removes 'copper golem' from SimpleEntityData and adds CopperGolemData allowing users to specify the copper state of the copper golem and whether they're waxed.
Adds a condition to check if a copper golem or a copper block is waxed.
Adds an effect to wax or unwax a copper golem or a copper block.
Adds an expression to get/set the time until the next oxidation for a copper golem.
Adds an expression to get/set the pose of a copper golem statue.
Adds an expression to get/set the copper state of a copper golem or a copper block.
Adds 'CopperState' that mimics 'WeatheringCopperState' for the versions that don't have it. Allowing easy use for getting and setting the copper states.
Registers ClassInfo for copper golem statue poses
Registers ClassInfo for 'CopperState' or 'WeatheringCopperState' if it exists.
Adds 'ReflectUtils' that is a utility class for common reflection and caches where possible. Reflection was needed for 'CopperState', 'ExprCopperState', and 'ExprCopperGolemOxidationTime' which led to the creation of ReflectUtils.
Testing Completed
EntityData.sk
EffWax.sk
ExprCopperGolemOxidationTime.sk
ExprCopperGolemPose.sk
ExprCopperState.sk
EffSecSpawn.sk
Supporting Information
N/A
Completes: none
Related: none