Global Options #8192
Open
Global Options #8192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
APickledWalrus and
Absolutionism
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
erenkarakal
added
enhancement
sovdeeth
requested changes
Sep 18, 2025
Comment on lines
+175
to
+177
| reloading(sender, "global options", logHandler); | ||
| GlobalOptions.load(); | ||
| reloaded(sender, logHandler, timingLogHandler, "global options"); |
There was a problem hiding this comment.
should also send a warning that the users should reload all scripts using global options.
Comment on lines
+86
to
+96
| private static void loadOptions(SectionNode sectionNode, String prefix, Map<String, String> options) { | ||
| for (Node node : sectionNode) { | ||
| if (node instanceof EntryNode) { | ||
| options.put(prefix + node.getKey(), ((EntryNode) node).getValue()); | ||
| } else if (node instanceof SectionNode) { | ||
| loadOptions((SectionNode) node, prefix + node.getKey() + ".", options); | ||
| } else { | ||
| Skript.error("Invalid line in options"); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
can we make this public so we don't have duplicated code between Struct and GlobalOptions
| # This file lets you set options globally. | ||
| # Options here will be available across all scripts. | ||
| # Scripts can override a global option by creating an option with the same name as the global one. | ||
| # When you edit this file, you must reload global-options and all script files that use global options. |
There was a problem hiding this comment.
Suggested change
| # When you edit this file, you must reload global-options and all script files that use global options. | |
| # When you edit this file, you must first reload global-options and then reload all the script files that use global options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The problem is explained in detail in #2028, but the general idea is that having a global options file makes it easier to change static values across lots of script files.
This PR also fixes another issue, using the code below:
{@hello}is parsed as a variable, because the script doesn't contain theoptionsstructure.Therefore, it doesn't throw the
unknown optionerror.Solution
Added a new
global-options.skfile inside/plugins/Skript/folder. The entries inside are loaded into a static map.Whenever
replaceOptionsis called, it checks if the script has that option first and returns it. If it doesn't, it gets the option from the static map instead. This lets scripts override global options.You can also use sections just like the structure version.
Testing Completed
Only manual testing, unit tests will be added after reviews when it's finalised
TODO (after finalised)
Completes: #2028
Related: none