Skip to content

Fixes and update Minecarts #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev/patch
Choose a base branch
from

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jul 21, 2025

Problem

minecart maps to the Minecart.class which is an interface... You can't spawn an interface.

Solution

Update the MinecartData class with proper handling of the different Minecart classes.

I also moved the WORLD_1_17_CONSUMER outside the try catch, because it doesn't need to be doing a try catch every time an entity is spawned.

All of these would fail prior to this pull request aside from the spawning of a storage minecart:

spawn a minecart at player # spawns RidableMinecart
if last spawned minecart is a storage minecart: #false
if last spawned minecart is a minecart: #true
if last spawned minecart is a regular minecart: #true
spawn a storage minecart at player # spawns StorageMinecart
if last spawned minecart is a storage minecart: #true
if last spawned minecart is a minecart: #true
if last spawned minecart is a regular minecart: #false

Completes: #7663

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner July 21, 2025 07:40
@TheLimeGlass TheLimeGlass requested review from cheeezburga and erenkarakal and removed request for a team July 21, 2025 07:40
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 21, 2025
Copy link
Contributor

@Pesekjak Pesekjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@Pesekjak Pesekjak added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 21, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jul 21, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. needs reviews A PR that needs additional reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants