-
-
Notifications
You must be signed in to change notification settings - Fork 403
Fixes and update Minecarts #8064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheLimeGlass
wants to merge
4
commits into
SkriptLang:dev/patch
Choose a base branch
from
TheLimeGlass:fix/minecarts
base: dev/patch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pesekjak
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Absolutionism
suggested changes
Jul 21, 2025
TheLimeGlass
commented
Jul 21, 2025
Co-authored-by: SirSmurfy2 <[email protected]>
Co-authored-by: SirSmurfy2 <[email protected]>
Absolutionism
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
needs reviews
A PR that needs additional reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
minecart
maps to the Minecart.class which is an interface... You can't spawn an interface.Solution
Update the MinecartData class with proper handling of the different Minecart classes.
I also moved the
WORLD_1_17_CONSUMER
outside the try catch, because it doesn't need to be doing a try catch every time an entity is spawned.All of these would fail prior to this pull request aside from the spawning of a storage minecart:
Completes: #7663