Tool Components #7200
Open
Tool Components #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusezion
suggested changes
Nov 8, 2024
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/ToolRuleWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/ToolRuleWrapper.java
Outdated
Show resolved
Hide resolved
Comment on lines
+26
to
+29
| Skript.registerCondition(CondToolRuleDrops.class, ConditionType.PROPERTY, | ||
| "[the] tool rule drops of %toolrules% (is|are) enabled", | ||
| "[the] tool rule drops of %toolrules% (is|are) disabled" | ||
| ); |
There was a problem hiding this comment.
Any chance we can possibly get one that reflects the behavior more?
loop tool rules of tool component of {_item}:
loop-tool rule is correct for drops
broadcast "%loop-tool rule% is correct for drops"
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/EffSecCreateToolRule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/EffSecCreateToolRule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolCompRules.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolCompRules.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolRuleBlocks.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolRuleBlocks.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolRuleSpeed.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add support for the upcoming Tool Components to Skript.
This will be marked as draft due to Tool Components being ApiStatus.Experimental at this time.
Open to any syntax changes.
Target Minecraft Versions: any
Requirements: none
Related Issues: none