Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events in StructParse #7067

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Conversation

Efnilite
Copy link
Member

Description

Fix events not working in StructParse.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7066

@Efnilite Efnilite added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Sep 11, 2024
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@Pikachu920 Pikachu920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@Efnilite Efnilite added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 11, 2024
@Efnilite Efnilite mentioned this pull request Sep 11, 2024
@sovdeeth sovdeeth merged commit 86742a9 into SkriptLang:dev/patch Sep 12, 2024
6 checks passed
stop

test "events in structs":
assert {StructEvent::parse::*} is not set with "using event in struct caused an error"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this return a value to ensure that the parse section parsed?

@Efnilite Efnilite deleted the events-in-structs branch September 22, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants