-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add condition type to fix parsing order #5809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'd like to make sure this isn't going to (somehow) break a bunch of scripts by changing the parsing orders.
2.8 betas will find out, I didn't find any from the tests, but it gets the proper conditions to work, so that's a plus. |
bd134d0
to
3f08853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts need fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is fine. The idea of condition priorities exists in #6246 which may end up getting merged for 2.10 (meaning this PR may only need to set priorities for something like CondCompare)
Co-authored-by: Patrick Miller <[email protected]>
When I created this pull request, I wanna add that this fix actually turned out surprisingly well, it fixed so many issues, and it's very simple in the fact that it's just modifying the list order like Expressions with ExpressionType. |
Oh yeah I think the idea is good. I'm fine with merging this. |
Description
Add condition type to fix parsing order. This is exactly the same as ExpressionType, shouldn't be a huge impact at all.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5536, #5804
this probably fixes other issues too.