Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mangademon): rewrite most of the source to account for a site remake #756

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

AlokSwaminathan
Copy link
Contributor

@AlokSwaminathan AlokSwaminathan commented Sep 4, 2024

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

Closes #753

src/rust/en.mangademon/src/parser.rs Outdated Show resolved Hide resolved
Copy link
Owner

@Skittyblock Skittyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device

@AlokSwaminathan
Copy link
Contributor Author

seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device

I've been reading from mangademon with this version of the source for a few weeks, I have 60 from it and I haven't noticed any issues. What chapter on martial peak are you having problems with, I tested a few chapters on there and they seem to work for me.

@Skittyblock
Copy link
Owner

interestingly enough, it's only happening when run on the simulator. none of the images load for me on device though. the culprit for martial peak is /chaptered.php?manga=1&chapter=3705, which I can see on the site is listed twice. this is their mistake, but you should probably filter out duplicates on our end within the source

@AlokSwaminathan
Copy link
Contributor Author

I took a look at 3705 and it seems to work on my phone even though there were chapters with that number. I just went ahead and removed duplicates anyway though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manga Demon app source not working
2 participants