fix(xoxocomics): update url #735
Merged
Annotations
1 error and 10 warnings
Lint sources
Process completed with exit code 1.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, Ana06/[email protected], actions/cache@v3, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Lint sources:
src/rust/wpcomics/template/src/template.rs#L191
warning: the borrowed expression implements the required traits
--> template/src/template.rs:191:36
|
191 | let details = unsafe { Node::new(&CACHED_MANGA.clone().unwrap())? };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `CACHED_MANGA.clone().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
Lint sources:
src/rust/wpcomics/template/src/template.rs#L241
warning: the borrowed expression implements the required traits
--> template/src/template.rs:241:33
|
241 | let html = unsafe { Node::new(&CACHED_MANGA.clone().unwrap())? };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `CACHED_MANGA.clone().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
Lint sources:
src/rust/wpcomics/template/src/template.rs#L280
warning: this manual char comparison can be written more succinctly
--> template/src/template.rs:280:39
|
280 | String::from(split[1]).replacen(|char| char == ':' || char == '-', "", 1);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[':', '-']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
|
Lint sources:
src/rust/wpcomics/template/src/template.rs#L284
warning: this manual char comparison can be written more succinctly
--> template/src/template.rs:284:39
|
284 | String::from(split[1]).replacen(|char| char == ':' || char == '-', "", 1);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[':', '-']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
|
Run actions-rs/toolchain@v1
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Run actions-rs/toolchain@v1
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Run actions-rs/toolchain@v1
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Run actions-rs/toolchain@v1
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading