Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mangademon): rewrite most of the source to account for a site remake #756

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix(mangademon): rewrite most of the source to account for a site remake #756

wants to merge 22 commits into from
+151 −169

Conversation

AlokSwaminathan
Copy link
Contributor

@AlokSwaminathan AlokSwaminathan commented Sep 4, 2024 •
edited
Loading

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

Closes #753

@AlokSwaminathan
fix: update BASE_URL
a633fe5
@AlokSwaminathan
fix: update manga list path
8dc5128
@AlokSwaminathan
fix: add break to stop unecessary matching
4edc27e 
If searching then other params just don't work, no reason to check for them and append them to the url
@AlokSwaminathan
fix: parse_manga_list
be156ff
@AlokSwaminathan
chore: formatting
295ca5c
@AlokSwaminathan
fix: get_manga_id
48d5f06
@AlokSwaminathan
fix: get_manga_url
6a3b233
@AlokSwaminathan
feat: add parsing for latest manga listings
a822f26
@AlokSwaminathan
chore!: format parse_latest_manga_list
3acbaf1
@AlokSwaminathan
fix: get_manga_details
d6edf3a
@AlokSwaminathan
fix: get_chapter_list parse_chapter_list
5061378
@AlokSwaminathan
fix: add url to manga details
3bdf896
@AlokSwaminathan
chore: remove unused function
521976c
@AlokSwaminathan
fix: make chapter use chapter id not manga id
125ac4e
@AlokSwaminathan
fix: get_page_list parse_page_list
2f5d2bc
@AlokSwaminathan
feat: make chapter id include numbered manga id
e96a96d
@AlokSwaminathan
chore: update source version and URL
b17374d
@AlokSwaminathan
chore: format files
4ce2e92
Skittyblock
Skittyblock requested changes Sep 16, 2024
View reviewed changes
src/rust/en.mangademon/src/parser.rs Outdated Show resolved Hide resolved
Skittyblock
Skittyblock requested changes Sep 29, 2024
View reviewed changes
Copy link
Owner

@Skittyblock Skittyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device

@AlokSwaminathan
Copy link
Contributor Author

seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device

I've been reading from mangademon with this version of the source for a few weeks, I have 60 from it and I haven't noticed any issues. What chapter on martial peak are you having problems with, I tested a few chapters on there and they seem to work for me.

@Skittyblock
Copy link
Owner

interestingly enough, it's only happening when run on the simulator. none of the images load for me on device though. the culprit for martial peak is /chaptered.php?manga=1&chapter=3705, which I can see on the site is listed twice. this is their mistake, but you should probably filter out duplicates on our end within the source

@AlokSwaminathan
Copy link
Contributor Author

I took a look at 3705 and it seems to work on my phone even though there were chapters with that number. I just went ahead and removed duplicates anyway though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skittyblock Skittyblock Skittyblock requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manga Demon app source not working
2 participants
@AlokSwaminathan @Skittyblock