Kediny xoxocomic #984
Annotations
1 error and 16 warnings
lint
Process completed with exit code 1.
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, Ana06/[email protected], actions/cache@v3, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
unneeded `return` statement:
src/rust/wpcomics/template/src/helper.rs#L8
warning: unneeded `return` statement
--> template/src/helper.rs:8:3
|
8 | / return temp
9 | | .replacen("cimoC", "", 1)
10 | | .chars()
11 | | .rev()
12 | | .collect::<String>();
| |________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
8 ~ temp
9 ~ .replacen("cimoC", "", 1)
10 ~ .chars()
11 ~ .rev()
12 ~ .collect::<String>()
|
|
unneeded `return` statement:
src/rust/wpcomics/template/src/helper.rs#L14
warning: unneeded `return` statement
--> template/src/helper.rs:14:3
|
14 | return temp.chars().rev().collect::<String>();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
14 - return temp.chars().rev().collect::<String>();
14 + temp.chars().rev().collect::<String>()
|
|
the borrowed expression implements the required traits:
src/rust/wpcomics/template/src/template.rs#L191
warning: the borrowed expression implements the required traits
--> template/src/template.rs:191:36
|
191 | let details = unsafe { Node::new(&CACHED_MANGA.clone().unwrap())? };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `CACHED_MANGA.clone().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
the borrowed expression implements the required traits:
src/rust/wpcomics/template/src/template.rs#L241
warning: the borrowed expression implements the required traits
--> template/src/template.rs:241:33
|
241 | let html = unsafe { Node::new(&CACHED_MANGA.clone().unwrap())? };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `CACHED_MANGA.clone().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
this manual char comparison can be written more succinctly:
src/rust/wpcomics/template/src/template.rs#L280
warning: this manual char comparison can be written more succinctly
--> template/src/template.rs:280:39
|
280 | String::from(split[1]).replacen(|char| char == ':' || char == '-', "", 1);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[':', '-']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
|
this manual char comparison can be written more succinctly:
src/rust/wpcomics/template/src/template.rs#L284
warning: this manual char comparison can be written more succinctly
--> template/src/template.rs:284:39
|
284 | String::from(split[1]).replacen(|char| char == ':' || char == '-', "", 1);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[':', '-']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
|
creating a shared reference to mutable static is discouraged:
src/rust/wpcomics/template/src/template.rs#L56
warning: creating a shared reference to mutable static is discouraged
--> template/src/template.rs:56:14
|
56 | if unsafe { CACHED_MANGA_ID.is_some() } && unsafe { CACHED_MANGA_ID.clone().unwrap() } == url {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
|
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
= note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives
= note: `#[warn(static_mut_refs)]` on by default
|
creating a shared reference to mutable static is discouraged:
src/rust/wpcomics/template/src/template.rs#L56
warning: creating a shared reference to mutable static is discouraged
--> template/src/template.rs:56:54
|
56 | if unsafe { CACHED_MANGA_ID.is_some() } && unsafe { CACHED_MANGA_ID.clone().unwrap() } == url {
| ^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
|
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
= note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives
|
creating a shared reference to mutable static is discouraged:
src/rust/wpcomics/template/src/template.rs#L72
warning: creating a shared reference to mutable static is discouraged
--> template/src/template.rs:72:15
|
72 | if unsafe { VINAHOST_COOKIE.is_some() } {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
|
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
= note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives
|
creating a shared reference to mutable static is discouraged:
src/rust/wpcomics/template/src/template.rs#L75
warning: creating a shared reference to mutable static is discouraged
--> template/src/template.rs:75:14
|
75 | unsafe { VINAHOST_COOKIE.clone().unwrap() }.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
|
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
= note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|