-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 : Fix GIF and WEBP Edge Case Handling #2882
Open
JimBobSquarePants
wants to merge
8
commits into
release/3.1.x
Choose a base branch
from
js/fix-2866
base: release/3.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
requested review from
tocsoft,
antonfirsov,
dlemstra,
brianpopow and
Copilot
February 7, 2025 05:51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- tests/Images/External/ReferenceOutput/GifDecoderTests/Issue1962_Rgba32_issue1962_tiniest_gif_1st.png: Language not supported
- tests/Images/External/ReferenceOutput/GifDecoderTests/Issue2012BadMinCode_Rgba32_issue2012_drona1.png: Language not supported
- tests/Images/Input/Gif/issues/issue_2866.gif: Language not supported
- tests/Images/Input/Webp/issues/Issue2866.webp: Language not supported
- src/ImageSharp/Formats/Gif/GifEncoderCore.cs: Evaluated as low risk
- tests/ImageSharp.Tests/TestUtilities/ReferenceCodecs/MagickReferenceDecoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/Lossy/Vp8Decoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/BitReader/BitReaderBase.cs: Evaluated as low risk
- tests/ImageSharp.Tests/Formats/Png/PngEncoderTests.cs: Evaluated as low risk
- tests/ImageSharp.Tests/TestImages.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/WebpBlendMethod.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
tests/ImageSharp.Tests/Formats/Gif/GifEncoderTests.cs:389
- [nitpick] The test method name GifEncoder_CanDecode_Issue2866 is misleading since it is testing encoding, not decoding. It should be renamed to GifEncoder_CanEncode_Issue2866.
public void GifEncoder_CanDecode_Issue2866<TPixel>(TestImageProvider<TPixel> provider)
src/ImageSharp/Formats/Webp/WebpAnimationDecoder.cs:89
- The comment should reflect the correct type for backgroundColor, which is TPixel instead of Color.
/// <param name="backgroundColor">The default background color of the canvas in.</param>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #2866
There's quite a lot going on here:
I'll have to manually rework this for V4 as the code base has migrated significantly there.