Fixed endless loop that would happen if an attribute was omitted in a…

… predicate instantiation
SitecoreUnicorn · May 4, 2021 · b0ae957 · b0ae957
1 parent 8716fe4
commit b0ae957
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/SharedAssemblyInfo.cs b/src/SharedAssemblyInfo.cs
@@ -4,7 +4,7 @@
 
 [assembly: AssemblyProduct("Unicorn")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("4.1.4.0")]
-[assembly: AssemblyFileVersion("4.1.4.0")]
-[assembly: AssemblyInformationalVersion("4.1.4")]
+[assembly: AssemblyVersion("4.1.5.0")]
+[assembly: AssemblyFileVersion("4.1.5.0")]
+[assembly: AssemblyInformationalVersion("4.1.5-pre1")]
 [assembly: CLSCompliant(false)]
diff --git a/src/Unicorn/Configuration/PredicatePreset.cs b/src/Unicorn/Configuration/PredicatePreset.cs
@@ -68,14 +68,19 @@ protected virtual XmlElement ReplaceValues(Dictionary<string, string> replacers,
 			// ReSharper disable once PossibleNullReferenceException
 			foreach (XmlNode att in clone.Attributes)
 			{
-				while (att.Value.Contains("$"))
+				if (att.Value.Contains("$"))
 				{
 					didReplacement = true;
 
 					foreach (var replacerKey in replacers.Keys)
 					{
 						att.Value = Regex.Replace(att.Value, "\\$" + replacerKey, replacers[replacerKey], RegexOptions.IgnoreCase);
 					}
+
+					if (att.Value.Contains("$"))
+					{
+						throw new InvalidOperationException($"Predicate Preset '{((XmlElement)includeElement.ParentNode).Attributes["id"].Value}' could not be expanded, there are unresolved token attributes '{att.Value}'");
+					}
 				}
 			}