Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Ensure locales are compared case-insensitively in redirects middleware #2056

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Mar 19, 2025

Description / Motivation

We must ensure redirect rules specified like 'pl-pl/mypath' would still activate if matching 'pl-PL' locale, despite difference in case.

Testing Details

  • Unit Test Adjusted
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team March 19, 2025 13:33
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However I am thinking, does it make sense to add a test for case sensitive path redirect with and without locale?

@art-alexeyenko
Copy link
Contributor Author

@yavorsk

However I am thinking, does it make sense to add a test for case sensitive path redirect with and without locale?

The existing unit test already tests for lowercase locale in redirect pattern, I think we're covered here.

@art-alexeyenko art-alexeyenko merged commit 77c6d96 into dev Mar 19, 2025
1 check passed
@art-alexeyenko art-alexeyenko deleted the bugfix/jss-5470-case-sense branch March 19, 2025 14:27
yavorsk pushed a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants