Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fields property type in PlaceholderProps interface #2043

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

st3phan
Copy link
Contributor

@st3phan st3phan commented Feb 12, 2025

Fixed the fields property type in the PlaceholderProps interface so it matches the ComponentFields type.

Description / Motivation

Fixes: #2042

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

st3phan and others added 3 commits February 12, 2025 17:15
Added Item to the fields type so it matches the `ComponentFields` type.
@illiakovalenko
Copy link
Contributor

@st3phan Thank you for your contribution! I've added a CHANGELOG entry and merged it

@illiakovalenko illiakovalenko merged commit 84abc41 into Sitecore:dev Feb 26, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types of PlaceholderProps['fields'] incorrect
2 participants