feature: fine-granular type system #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
force-pushed
the
feature/rework-typing
branch
from
154dfc5
to
4313e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18.
This change allows more fine-granular analysis as parameters and return types are not represented by
PsiTypeanymore, but instead our own type system that can have bottom and top types itself.One example where this is beneficial:
Before,
identitywould just be a bottom type, anddropReturncould not make it any more precise. Now we know thatdroppedwill have avoidreturn type even if the parameter is still unknown.Note that this PR is not perfect. It might result in wrong/unexpected types when any inputs are somehow incompatible or unknown or bad. Future work will make more methods more precise and correct.