Add JEI bridge #22
Merged
Add JEI bridge #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, I can have a look at that part. Is there anything else required to bridge the APIs? |
|
No I checked those are the only classes exclusive to the JEI Fabric API (https://github.com/mezz/JustEnoughItems/tree/1.20/FabricApi/src/main/java/mezz/jei/api/fabric) |
|
Ah I may have misunderstood, I tested this and the plugin loading worked fine, the only issue was the JEI Fabric API classes not being loaded with log messages such as |
|
The relocation code can be safely removed. JEI puts its fabric-specific classes in a unique |
|
Ah that's a relief |
Su5eD
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as draft as it currently doesn't seem to relocate/inject API classes properly, help would be appreciated :)