Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Species] Invert Poison Damage for SlimePeople #36

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Feb 9, 2023

Changelog

🆑

  • tweak: SlimePeople's Poison damage is inverted, meaning toxins will heal and toxin medicines will hurt.

@DEATHB4DEFEAT DEATHB4DEFEAT self-assigned this Feb 9, 2023
@github-actions github-actions bot added Status: Needs Review Someone please review this No C# labels Feb 9, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT removed the Status: Needs Review Someone please review this label Mar 28, 2023
@github-actions github-actions bot added the Changes: YML Changes any yml files label Apr 15, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Slimin [Species] Slimin Apr 15, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT added this to the Unique Species milestone Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 9, 2023
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Oct 14, 2023
@github-actions github-actions bot added the Changes: C# Changes any cs files label Oct 14, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title [Species] Slimin [Species] Invert Poison Damage for SlimePeople Oct 14, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Oct 14, 2023
26 tasks
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review October 14, 2023 23:30
Resources/Prototypes/Damage/modifier_sets.yml Outdated Show resolved Hide resolved
Content.Server/Chemistry/ReagentEffects/HealthChange.cs Outdated Show resolved Hide resolved
Comment on lines +34 to +38
- type: damageModifierSet
id: SlimeReagents
coefficients:
Poison: -1
minimumDamageToDamage: -999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a negative flat reduction. The effects of this would be to increase healing before reversing it, making it more deadly, and to lower damage before reversing it, making it less healing. I think this is good for balance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you're right, but also it seems to be your problem now :P

Either way, I actually meant a standard flat reduction- but it should also increase the power of healing.

@Pspritechologist
Copy link
Member

Update their Guidebook entry

@github-actions github-actions bot added Changes: Documentation Changes any xml or md files Status: Needs Review Someone please review this labels Oct 15, 2023
@@ -79,6 +79,16 @@
- BleedersBite
- type: ReagentDamageModifier
modifierSet: SlimeReagents
- type: Temperature
heatDamageThreshold: 422
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is significantly past the point of boiling, I do not think Slimes would be happy here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warm :)

@@ -79,6 +79,16 @@
- BleedersBite
- type: ReagentDamageModifier
modifierSet: SlimeReagents
- type: Temperature
heatDamageThreshold: 422
coldDamageThreshold: 285
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is near-ish to room temperature, are you sure they should start dying at this point?

I would recommend that you set the damages to be more extreme rather than the temperature limits, and then instead play with the ThermalRegulator component. You can use that to edit their comfortable range, which will be a more nuanced effect than just a death-limit.

@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 3-Medium Needs to be resolved at some point Status: Do Not Merge Do not merge Size: Medium For medium issues/PRs labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: Medium For medium issues/PRs Status: Do Not Merge Do not merge Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants