Jukebox #208
Open
Jukebox #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
|
RSI Diff Bot; head commit 5618361 merging into f179799 Resources/Textures/SimpleStation14/Structures/Machines/jukebox.rsi
|
DEATHB4DEFEAT
added
Priority: 3-Medium
Content.Server/SimpleStation14/Jukebox/JukeboxSystems.Interactions.cs
Outdated
Show resolved
Hide resolved
Comment on lines
30
to
39
| /// <summary> | ||
| /// Serialized as a string because TimeSpan is not serializable, and converted to a TimeSpan with <see cref="ToTimeSpan"/>. | ||
| /// </summary> | ||
| [DataField("duration")] | ||
| private string DurationString { get; } = default!; | ||
|
|
||
| /// <summary> | ||
| /// Actual duration as a TimeSpan. | ||
| /// </summary> | ||
| public TimeSpan Duration => ToTimeSpan(DurationString); |
There was a problem hiding this comment.
We should just learn how to make a serializer... I honestly don't think it'd be that hard.
|
Also note; The system needs to react to the unpaused event so that the saved time is set correctly. |
Felt like I did more 😔
…le now), removable decorative portions, lots of commenting, and some general clean up. Also added a couple extra Jukebox examples in the YAML
… to its song state. It also plays when you punch it.
Apart from adding a whack ton of songs, just loads of general clean up and additions before release.
Also slightly cleaner, a fix or two
Danya Vodovoz is out, Dieter van der Westen is in. It was time for a change :) Also adds a hand full new Jukebox tracks.
|
@DEATHB4DEFEAT You gotta make nicer UI icons, and increase the size of the UI a bit. It needs a once over (is all of the text in it good to keep?), and then this is ready for prime time baybeeee |
|
|
||
| namespace Content.Shared.SimpleStation14.Jukebox; | ||
|
|
||
| public sealed class SharedJukeBoxSystem : EntitySystem |
There was a problem hiding this comment.
This is ClientSide, not Shared.
| public const string PortSkip = "Skip"; | ||
| public const string PortPause = "Pause"; | ||
| public const string PortUnPause = "Unpause"; | ||
| public const string PortTogglePuase = "TogglePause"; |
| /// If the Jukebox is already playing a song, it will be stopped and replaced with the new song. | ||
| /// To queue a song instead, see <see cref="TryQueueSong"/>. | ||
| /// </summary> | ||
| /// <param name="song">The JukeboxTrackPrototype representing the song to be played.</param> |
| [Dependency] private readonly DeviceLinkSystem _link = default!; | ||
| [Dependency] private readonly SharedAppearanceSystem _appearance = default!; | ||
|
|
||
| public const string PortSongPlayed = "Start"; |
There was a problem hiding this comment.
These really shouldn't be hardcoded I don't think, but making them variables makes checking them a pain...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a functional Jukebox to the stations! Capable of playing music, being paused, queueing up songs, and a whole load of other stuff the engine doesn't actually allow for yet ' v ,
Tasks
[ ] Sync music over the network for new joinsWill probably require a pretty heavy rewrite, this is fine for now.Uses stock parts, that countsMedia
Youtube Demonstration
JukeboxFonzie.mp4
Changelog
🆑 Pspritechologist & DEATHB4DEFEAT