Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Issues #62

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve Issues #62

wants to merge 4 commits into from

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Mar 16, 2024

Description

I realized while going to make some issues that they suck, so here are some improvements

I've also added three new Type: labels for issue use

@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 5-Very Small For especially small issues/PRs Priority: 2-High Needs to be resolved as soon as possible labels Mar 16, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Mar 16, 2024
Comment on lines +1 to +27
---
name: Request a Feature
about: "Template for noting future planned features. Please ask for approval in the Discord if you aren't an organization Member before posting a feature request"
title: ''
labels: ''
assignees: ''

---

<!--
This is a loose format, write this however you need to
Remove these comments before submitting
-->

# Description
<!--
Explain your request in as much detail as you can
-->

I want Goldfish crackers

# Media
<!--
If applicable, add images or even a video to help explain your suggestion
-->

![Example Screenshot](https://example.com/thisimageisntreal.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this instead? Deeper layout, asks for more and provides more. Higher bar for entry as well when people see this.

Suggested change
---
name: Request a Feature
about: "Template for noting future planned features. Please ask for approval in the Discord if you aren't an organization Member before posting a feature request"
title: ''
labels: ''
assignees: ''
---
<!--
This is a loose format, write this however you need to
Remove these comments before submitting
-->
# Description
<!--
Explain your request in as much detail as you can
-->
I want Goldfish crackers
# Media
<!--
If applicable, add images or even a video to help explain your suggestion
-->
![Example Screenshot](https://example.com/thisimageisntreal.png)
---
---
name: Request a Feature
about: "Template for noting future planned features. Ask for approval in the Discord if you aren't an organization Member before posting a feature request to get quick feedback on it, and find out if it's something where generally interested in."
title: ''
labels: ''
assignees: ''
---
<!--
This is a loose format and does not strictly need to be kept, adjust as you'd like.
Ensuere you remove all comments (anything after <!-- to the ending characters, including the start and end characters in question) before submitting your issue.
-->
# Identified Issue or Content Gap
<!--
Explain what you have identified as an issue or gap, be it a power-imbalence, something you feel would make the game better, or simply a cool idea you've come up with.
-->
I am currently hungry. Note that I am not *always* hungry.
This results in me being cranky, and not wanting to do anything.
# Proposed Solution
<!--
Explain your idea or fix in as much detail as you can.
-->
I feel that eating gold fish crackers would solve this, as they would fill the vacuous hole within myself.
# Implementation Details
<!--
If capable, adding details on how you would implement this suggestion is greatly appreciated.
If you are currently unaware, or lack the required skills to understand how to implement it, leave this feild blank. Someone else may fill it in later.
-->
Goldfish crackers can be obtained from the kitchen, my mom put them there last weekend.
About 47 would fill me full. Below is the sequence of events to get them, in psuedocode.
\```
[0] MOVE_TO 'kitchen'
[1] OPEN 'cupboard'
[2] GET 'gf_crackers'
!MARK 'yum'
[3] GET 'goldfish'
[4] EAT 'goldfish'
!IF 'gf_crackers' != 0
GOTO 'yum'
[5] SMILE_BACK
\```
# Media
<!--
If applicable, add images or even a video to help explain your suggestion.
You can simply drag image files onto this page and GitHub will embed them for you.
This can be an example of the problem, or a prototype/example of the suggestion.
-->
![Example Screenshot](https://picsum.photos/512/288)

Had to escape the code block :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll read this one in deeper detail later, all read-out right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto as PR template

.github/ISSUE_TEMPLATE/issue_report.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
DEATHB4DEFEAT pushed a commit that referenced this pull request Jun 2, 2024
## Mirror of PR #977: [pebble minor patch
3²](DeltaV-Station/Delta-v#977) from <img
src="https://avatars.githubusercontent.com/u/131613340?v=4"
alt="DeltaV-Station" width="22"/>
[DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v)

<aside>PR opened by <img
src="https://avatars.githubusercontent.com/u/149102472?v=4"
width="16"/><a href="https://github.com/UnicornOnLSD"> UnicornOnLSD</a>
at 2024-03-18 16:00:47 UTC</aside>
<aside>PR merged by <img
src="https://avatars.githubusercontent.com/u/149102472?v=4"
width="16"/><a href="https://github.com/UnicornOnLSD"> UnicornOnLSD</a>
at 2024-03-18 18:35:38 UTC</aside>
<sup>

`627e535e3782c3737bb961d3bdfba88abc49ad7c`

</sup>

---

PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:
- Status: Needs Review
- Changes: Map


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> minor map tweaks on pebble.
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> per request, blatant problems I've seen and player convenience
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> moved east solars up a notch not to be a problem with cargo shuttle
> fixed cryosleep casket sending you in a wall (hopefully)
> fixed station beacons not to overlap
> fixed bombing sites and warps
> 
> 🆑
> 
> - tweak: pebble minor patch 3
> 


</details>

Co-authored-by: UnicornOnLSD <[email protected]>
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants