Port Drop on Slip #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finket
requested review from
Pspritechologist and
DEATHB4DEFEAT
as code owners
github-actions
bot
added
Status: Needs Review
DEATHB4DEFEAT
requested changes
Feb 25, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]>
DEATHB4DEFEAT
requested changes
Mar 6, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DEATHB4DEFEAT
approved these changes
Mar 28, 2024
Pspritechologist
requested changes
Mar 29, 2024
| namespace Content.Server.SimpleStation14.Slippery; | ||
|
|
||
| /// <summary> | ||
| /// Uses provided chance to try and drop the item when slipped, if equipped. |
There was a problem hiding this comment.
Suggested change
| /// Uses provided chance to try and drop the item when slipped, if equipped. | |
| /// Marks this item as one that may be dropped when its wearer slips with it equipped. |
There was a problem hiding this comment.
Currently looking at https://www.github.com/space-wizards/space-station-14/issues/9702 as the solution.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A Parkstation list item from #2
I have not made any changes to the code, it might be worth looking at the clothing YAMLs to see if anything should be added or changed.
Todo
Changelog
🆑