-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Shadowkin #23
base: master
Are you sure you want to change the base?
Port Shadowkin #23
Conversation
RSI Diff Bot; head commit 65e73ff merging into 739d0bf Resources/Textures/Parkstation/Interface/Actions/shadowkin_icons.rsi
Resources/Textures/Parkstation/Interface/Alerts/shadowkin_power.rsi
Resources/Textures/Parkstation/Mobs/Species/shadowkin.rsi
Resources/Textures/Parkstation/Objects/Fun/Plushies/shadowkin.rsi
|
Content.Server/SimpleStation14/Species/Shadowkin/Systems/ShadowkinPowerSystem.Rest.cs
Outdated
Show resolved
Hide resolved
Some small things had to be refactored for PR209 above. Wrote them and reverted for now since that PR is a draft. |
Couldn't keep looking at the "Entites" directory, had to fix the typo :D |
Amazing |
I didn't want to do a review...
Empathy and suffocation fixed. Major comments addressed. |
Fixed so that shadowkin effectively don't need to breath, but they are still BaseMobHuman and have the Respirator component. Also removed the psionic roll chance from the inherited PotentialPsionic component. As far as I can tell, Shadowkin should be in a totally usable state now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I move the prebase Shadowkin update here or finish it there then redo it here?
Content.Client/SimpleStation14/Species/Shadowkin/Systems/ShadowkinSystem.Tint.cs
Outdated
Show resolved
Hide resolved
Content.Client/SimpleStation14/Species/Shadowkin/Systems/ShadowkinSystem.Tint.cs
Outdated
Show resolved
Hide resolved
Content.Server/SimpleStation14/Species/Shadowkin/Systems/ShadowkinPowerSystem.Darken.cs
Outdated
Show resolved
Hide resolved
Content.Server/SimpleStation14/Species/Shadowkin/Systems/ShadowkinSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/SimpleStation14/Species/Shadowkin/Systems/ShadowkinPowerSystem.cs
Outdated
Show resolved
Hide resolved
roundStart: true | ||
prototype: MobShadowkin | ||
sprites: MobShadowkinSprites | ||
defaultSkinTone: "#FFFFFF" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a default eye color or something similar? Would be good to avoid clueless people never getting powers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Laki asked me about why their Shadowkin never got any powers and I realized that taking away their powers for simply having black eyes is pretty lame and is not communicated, I'll probably remove that and keep it a trait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to do this on the next update or should I remove the eye color blackeye-ing here myself?
Co-authored-by: DEATHB4DEFEAT <[email protected]>
After #56 gets merged the color tint shader needs to be toggleable via the client's species vision trait option in their settings. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Resources/Prototypes/Parkstation/Entities/Mobs/Player/shadowkin.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Parkstation/Entities/Mobs/Player/shadowkin.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Description
Port over Shadowkin. #2
Simple-Station/Parkstation#42
This PR creates a lot of directories not yet ported to this rebase.
Many other directories which are required in the original PRs are not yet created / addressed.
Tasks
TODO SHADOWKIN PRS TO CHECK:
More todo, notes, and comments to address last (tentative):
I know this is a mess at the moment. Let me cook B-)