Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Americanize Contests System #814

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

VMSolidus
Copy link
Member

Description

I have updated the Contests System to make it safe to use by Americans. This is accomplished by adding very helpful warning labels, as well as restricting the Range of all its functions so that they cannot return either a negative number, or a zero. Therefore, all Contests are now perfectly safe to divide by.

Changelog

🆑

  • tweak: ContestsSystem(Mass Contest, Stamina Contest, Health Contest, Mind Contest, Mood Contest, and Every Contest) have all been updated to be safe to divide by, since it is no longer possible for them to ever return 0. Instead they will just return 0.0000000000000000000000000000000000000000000001401298, so if you divide by an unclamped contest, I hope you like your function randomly returning the 32bit integer limit.
  • add: Warning labels have been added to all Contests to make them comply with the demands of the American consumer market.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Aug 28, 2024
@Elijahrane
Copy link
Contributor

Are changelogs supposed to be player-facing or not

Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a XMLDoc tag for arguments, you can move the remarks about the bypassClamp to those if you want.

@VMSolidus VMSolidus merged commit 058650e into Simple-Station:master Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants