Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPC Missing Deathgasp #800

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

VMSolidus
Copy link
Member

Description

IPC were missing a deathgasp, so I wrote one for them.

faridaiscute

Changelog

🆑

  • fix: IPC now have their own unique deathgasp message.

@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Aug 25, 2024
@@ -1,2 +1,7 @@
emote-deathgasp = seizes up and falls limp, {POSS-ADJ($entity)} eyes dead and lifeless...
silicon-emote-deathgasp =seizes up and falls limp...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the silicon deathgasp that is used in the original IPC PR. Remove if you want to replace it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've actually been wanting to replace the Deathgasps for awhile, so it's fine.

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 26, 2024
@DangerRevolution DangerRevolution added Priority: 4-Low Should be resolved at some point Size: 5-Very Small For especially small issues/PRs Type: Cleanup Like Rework but small and removed Status: Needs Review Someone please review this labels Aug 26, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Aug 29, 2024
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Aug 29, 2024
@VMSolidus VMSolidus merged commit 386d9ca into Simple-Station:master Aug 30, 2024
10 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Priority: 4-Low Should be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this Type: Cleanup Like Rework but small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants