Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages Markers #510

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

FoxxoTrystan
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan commented Jul 4, 2024

Description

Require #459

Add 3 optional settings for LanguagePrototypes to play with richtext tags to they could be reconized as Makings

color - Set a specefic color to the text.
fontId - Set a font to the text by using the Id.
fontSize - Set the size of the text

All 3 are optional if not set message will be handeled like normal.

This should be mostly used to know what language your currently speaking and assist with markings.
Take note those changes happent only in the TextBox chat, bubblechat is left unchanged.


TODO

  • Add Markings
  • Add Fonts

Media

image
image


Changelog

🆑 FoxxoTrystan

  • add: Languages are now marked in the chat!

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Jul 4, 2024
@PuroSlavKing
Copy link

Will there be language icons in the language selection menu, chat and in the text cloud? 🥺

@DangerRevolution
Copy link
Contributor

Will there be language icons in the language selection menu, chat and in the text cloud? 🥺

Not the author of the PR; but from what I've spoke to them:

  1. Menu can support icons
  2. Chat menu cannot support icons
  3. Chat cloud cannot support icons

2 and 3 would need very big changes to how the Chat Menu and Chat Cloud are formatted.

@FoxxoTrystan
Copy link
Contributor Author

Will there be language icons in the language selection menu, chat and in the text cloud? 🥺

Not the author of the PR; but from what I've spoke to them:

  1. Menu can support icons
  2. Chat menu cannot support icons
  3. Chat cloud cannot support icons

2 and 3 would need very big changes to how the Chat Menu and Chat Cloud are formatted.

They could but you would need to change compleatly the UI of both ends and by god... im not going to try to touch ANCIENT UI.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants