Felinid Soft Thieving + Trait

[WarMechanic]

Description

Reworks felinid thieving to no longer act like passive thieving gloves which grant invisible stripping (hereon referred to as hard stealing), in favour of soft thievery (hereon referred to as soft stealing).

Soft thievery comprises of the following:

• A smaller popup, with the thief anonymised.
• A visible doafter bar
• A 33% faster strip speed, that stacks with Thieving gloves
• An additional ability to identify hidden items to better plan your course of action

You no longer need to completely avoid felinids to maintain your precious items as long as you pay attention. For a felinid to utilise their thieving passive, they are encouraged to exploit any distractions to make moves on a target. If there is none, create one through conversation or other forms of player interaction. If you are suspected, persuade your victim that the thief is in fact, the other person.

A faster strip speed makes thief bonuses diegetic to other players, and also improves the value proposition of thieving gloves on someone who already has thieving bonuses.

Any other race can also gain soft thievery via a moderate costing trait. Non-felinid thieves are encouraged to exploit any felinids as a scapegoat.

---

TODO

Code

• IgnoreStripHidden - allows thieves to look into peoples pockets
• StripTimeMultiplier - stripping at a multiplicative rate helps strip bags/belts which creates trait value
• Stealthy > Stealth - rather than a bool, distinguishes stealth levels as an enum

Balance

• Soft thieves can identify items in pockets, which creates player agency
• Soft thieves steal 33% faster, which stacks with thieving gloves
• Victims to soft stealing get a smaller popup, useful if they're preoccupied
• Soft thievery is a trait, which Felinids get for free
• Felinids no longer hard steal items

Media

• Attach media

---

Media

---

Changelog

🆑

• add: Added the Thievery trait, which provides various soft stripping bonuses
• tweak: Felinids no longer have passive thieving gloves, they instead get the Thievery trait by default

[VMSolidus]

Holy shit congratulations on PR500 by the way!

[WarMechanic]

it appears something has gone wrong

[VMSolidus]

it appears something has gone wrong

It looks like you need to create a way to convert from ThievingStealth's sbyte to PopupType. Your best bet will likely be to use a Switch statement for this.

[WarMechanic]

oh shit ive been using boolean assignment when i could have done this, thats awesome

[WarMechanic]

Your best bet will likely be to use a Switch statement for this.

done, it still works ingame and i actually built it locally this time :)

[WarMechanic]

still works ingame, 1/4 the code used for popups

[DangerRevolution]

Does this have much impact on / from #205 and #224 ?

[WarMechanic]

Does this have much impact on / from #205 and #224 ?

because codewise this pr only really changes stealth to be an enum instead of a bool alongside other things, i dont think the merge conflict should be too hard to resolve

[VMSolidus]

Does this have much impact on / from #205 and #224 ?

because codewise this pr only really changes stealth to be an enum instead of a bool alongside other things, i dont think the merge conflict should be too hard to resolve

I'll hold you to that. I'm going to merge the strippablesystem doafter PRs, and then have you fix merge conflicts after the two are merged.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[WarMechanic]

why was the strip time multiplier variable changed to a timespan? it just broke the multiplication and caused any multiplier less than 1 to make strip times instant

in the merge i switched it back to being a float, i really dont see much of a difference otherwise

[VMSolidus]

why was the strip time multiplier variable changed to a timespan? it just broke the multiplication and caused any multiplier less than 1 to make strip times instant

in the merge i switched it back to being a float, i really dont see much of a difference otherwise

Hold off a bit until we merge the second one that fixes some issues that the first PR had.

[VMSolidus]

If you really want to get things quickly, you can cherrypick this and say that Felinid Soft Thieving depends on this PR:
#504

[WarMechanic]

im happy to wait until everything is ready, 0 second strip time would be awful for balance

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[DangerRevolution]

While Felinid thieving is contentious; we'll be revisiting species and mass .yaml changes when Common Core exists and can be re-adressed then or if it's an issue downstream somewhere; otherwise the changes are cool

stale