Localises #492
Open
Localises #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Localization
DangerRevolution
added
Priority: 5-Whenever
|
Setting to draft; it looks like I'm going to have to clean up a fair amount of the base entities that were localised. |
|
AFAIK entity names & descriptions are usually kept in-line so forks in other languages can easily localize them without modifying upstream code, this may disrupt the regular workflow. Not to mention having 1000 more files will slow down loading and make it harder to introduce changes without actually improving anything else... |
Not sure what you mean by this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Localises da game; opening this PR to run tests on Github and while I do manual checks; I will expand on this section later.
This PR cleans up the salad description; as that causes errors when running a locale script.
This PR cleans up the backpacks.yml folder in the Delta-V back clothing folder; as having a folder with .yml on the end of it caused errors in the script.
Some (many) entities with no description; and no description that can be inherited from a parent instead point to the parent to look for descriptions from that parent. This opens about 80 or so non-critical errors when building.
Needs a comb-through as some "entities" that aren't real entities haven't been localised. Such as "stress test" debug entities.
TODO