Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Parkstation Audio Library #457

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

VMSolidus
Copy link
Member

Description

By request from @DEATHB4DEFEAT , this ports Simple-Station/Parkstation#55

馃啈 VMSolidus

  • add: Many new sound effects have been implemented for items.

@VMSolidus VMSolidus changed the title Parkstation audio port Port Parkstation Audio Library Jun 13, 2024
@github-actions github-actions bot added Changes: Audio Changes any ogg files Changes: YML Changes any yml files labels Jun 13, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jun 14, 2024
@DangerRevolution DangerRevolution added Priority: 4-Low Should be resolved at some point Size: 2-Large For large issues/PRs Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase labels Jun 14, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this changes sounds as needed? Also; Shadowkin sounds? Are we porting those?

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 14, 2024
@VMSolidus
Copy link
Member Author

I assume this changes sounds as needed? Also; Shadowkin sounds? Are we porting those?

Yes, we are. :)

@DEATHB4DEFEAT
Copy link
Member

I assume this changes sounds as needed? Also; Shadowkin sounds? Are we porting those?

Yes, we are. :)

What for?

@VMSolidus
Copy link
Member Author

I assume this changes sounds as needed? Also; Shadowkin sounds? Are we porting those?

Yes, we are. :)

What for?

Audio library objects can be re-used and modified to suit other purposes, so of all the assets to store upstream, they're one of the most sensible. Even if Shadowkin aren't upstreamed to EE, having the audio files here still makes sense. Plus it was just part of the original PR that I cherrypicked here.

@DEATHB4DEFEAT
Copy link
Member

While playing, I noticed the cup pickup sound is very loud. #474 :)
I don't remember any other issues, might properly review this later but doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any ogg files Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 2-Large For large issues/PRs Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants