Tail Covers! #427

FoxxoTrystan · 2024-05-31T03:22:41Z

Description

Adds a new Layer called "tailcover" currently added for "Vulpkanin", "Lizards" and "Felinds" but easy to add to anyone else!

TODO

TailCover Sprites.
Clothing Tags
Minor Fix Harpies Tags

Media

Changelog

🆑

add: Tail Covers! No more our tails shall experience space!
fix: Fixed HapiesTags on Softsuit/Hardsuits

github-actions · 2024-05-31T03:23:15Z

RSI Diff Bot; head commit c47a4fb merging into e7fd3c7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/tailcover.rsi

State	Old	New	Status
tailcover-felinds			Added
tailcover-reptilian			Added
tailcover-vulpkanin			Added

Edit: diff updated after c47a4fb

Resources/Prototypes/Entities/Mobs/Species/base.yml

VMSolidus · 2024-05-31T05:29:36Z

Content.Shared/Clothing/EntitySystems/ClothingSystem.cs

+            _humanoidSystem.SetLayerVisibility(args.Equipee, HumanoidVisualLayers.Tail, true);
+            TryComp(args.Equipee, out AppearanceComponent? appearance);
+            _appearance.SetData(args.Equipee, TailVisuals.Tailcover, TailcoverVisuals.False, appearance);
+        }


I'm definitely not going to ask this of you, but seeing incredibly cursed visualizer code get extended even further, makes me realize I should probably revisit this later and expand that aforementioned component into one that lets you arbitrarily declare layers to be hidden when equipping clothing with a specific condition. Harpies want to hide their tail, everyone wants to hide their hair, harpies need to hide their wings, and their tail, and their ear tufts, it's all something I could finangle into a single check.

VMSolidus · 2024-05-31T05:33:43Z

Resources/Prototypes/DeltaV/Entities/Mobs/Species/vulpkanin.yml

+  - type: Tag
+    tags:
+    - CanPilot
+    - FootstepSound
+    - DoorBumpOpener
+    - HidesTail


Suggested change

- type: Tag

tags:

- CanPilot

- FootstepSound

- DoorBumpOpener

- HidesTail

- type: TailVisual

VMSolidus · 2024-05-31T05:34:39Z

Content.Shared/Clothing/EntitySystems/ClothingSystem.cs

@@ -140,6 +150,12 @@ protected virtual void OnGotUnequipped(EntityUid uid, ClothingComponent componen
            ToggleVisualLayer(args.Equipee, HumanoidVisualLayers.Hair, HairTag);
        if ((new string[] { "mask", "head" }).Contains(args.Slot) && _tagSystem.HasTag(args.Equipment, NoseTag))
            ToggleVisualLayer(args.Equipee, HumanoidVisualLayers.Snout, NoseTag);
+        if ((new string[] { "outerClothing" }).Contains(args.Slot) && _tagSystem.HasTag(args.Equipee, TailTag) && _tagSystem.HasTag(args.Equipment, TailTag))


Suggested change

if ((new string[] { "outerClothing" }).Contains(args.Slot) && _tagSystem.HasTag(args.Equipee, TailTag) && _tagSystem.HasTag(args.Equipment, TailTag))

if ((new string[] { "outerClothing" }).Contains(args.Slot) && HasComp<TailVisualComponent>(args.Equipee) && _tagSystem.HasTag(args.Equipment, TailTag))

VMSolidus · 2024-05-31T05:35:18Z

Content.Shared/Clothing/EntitySystems/ClothingSystem.cs

@@ -131,6 +135,12 @@ protected virtual void OnGotEquipped(EntityUid uid, ClothingComponent component,
            ToggleVisualLayer(args.Equipee, HumanoidVisualLayers.Hair, HairTag);
        if ((new string[] { "mask", "head" }).Contains(args.Slot) && _tagSystem.HasTag(args.Equipment, NoseTag))
            ToggleVisualLayer(args.Equipee, HumanoidVisualLayers.Snout, NoseTag);
+        if ((new string[] { "outerClothing" }).Contains(args.Slot) && _tagSystem.HasTag(args.Equipee, TailTag) && _tagSystem.HasTag(args.Equipment, TailTag))


Suggested change

if ((new string[] { "outerClothing" }).Contains(args.Slot) && _tagSystem.HasTag(args.Equipee, TailTag) && _tagSystem.HasTag(args.Equipment, TailTag))

if ((new string[] { "outerClothing" }).Contains(args.Slot) && HasComp<TailVisualComponent>(args.Equipee) && _tagSystem.HasTag(args.Equipment, TailTag))

VMSolidus · 2024-05-31T05:36:07Z

Resources/Prototypes/Entities/Mobs/Species/reptilian.yml

+  - type: Tag
+    tags:
+    - CanPilot
+    - FootstepSound
+    - DoorBumpOpener
+    - HidesTail


Suggested change

- type: Tag

tags:

- CanPilot

- FootstepSound

- DoorBumpOpener

- HidesTail

- type: TailVisual

VMSolidus · 2024-05-31T05:36:27Z

Resources/Prototypes/Nyanotrasen/Entities/Mobs/Species/felinid.yml

+  - type: Tag
+    tags:
+    - CanPilot
+    - FootstepSound
+    - DoorBumpOpener
+    - HidesTail


Suggested change

- type: Tag

tags:

- CanPilot

- FootstepSound

- DoorBumpOpener

- HidesTail

- type: TailVisual

VMSolidus · 2024-05-31T05:44:01Z

Resources/Textures/Clothing/tailcover.rsi/meta.json

+{
+    "version": 1,
+    "license": "CC-BY-SA-4.0",
+    "copyright": "TailCover by gentlebutter (588410099190726656) and ghostprince (115894681304301569)",
+    "size": {
+        "x": 32,
+        "y": 32
+    },
+    "states": [
+        {
+            "name": "tailcover-vulpkanin",
+            "directions": 4
+        },
+        {
+            "name": "tailcover-reptilian",
+            "directions": 4
+        },
+        {
+            "name": "tailcover-felinds",
+            "directions": 4
+        }
+    ]
+}


If you check in Resources/Textures/DeltaV/Mobs/Customization/Harpy, there is a stray png file listed as harpy_wingcover.png not present in any RSI. Do you mind moving it to this folder, and rename it to tailcover-harpy, then add the TailVisual component and required visual layers to Harpy?

Thanks. I'm having Still-Icarus make a wing cover for Harpies too, after this is merged I'll implement a wing cover system for Harpies so that they can finally have actual proper hardsuits.

PuroSlavKing · 2024-05-31T15:32:17Z

How about supporting the creation of custom sprites for each tail? Of course, it's good that there is at least something like this, but lizards have much more tails of different shapes, so it would be strange if they were displayed as standard.

Example of a super oddly shaped tail:

DEATHB4DEFEAT · 2024-05-31T15:39:51Z

How about supporting the creation of custom sprites for each tail? Of course, it's good that there is at least something like this, but lizards have much more tails of different shapes, so it would be strange if they were displayed as standard.

I've said something similar in Discord a couple times. I don't like the lack of customization being shown.

DangerRevolution · 2024-05-31T16:32:44Z

my main concern is with tale animations, what does this display if someone wags their tail as a lizard?

i'll also echo @DEATHB4DEFEAT and @PuroSlavKing, what happens if their tail isn't regularly shaped?

FoxxoTrystan · 2024-06-02T14:14:26Z

my main concern is with tale animations, what does this display if someone wags their tail as a lizard?

i'll also echo @DEATHB4DEFEAT and @PuroSlavKing, what happens if their tail isn't regularly shaped?

This is a layer its does not modify the orignal tail at all, just hides it.

FoxxoTrystan · 2024-06-02T14:16:08Z

How about supporting the creation of custom sprites for each tail? Of course, it's good that there is at least something like this, but lizards have much more tails of different shapes, so it would be strange if they were displayed as standard.

Example of a super oddly shaped tail:

Making a cover sprite for each clothing could be possible... but someone has to make a sprite for EACH SINGLE TAILCOVERS.
I could add the possibility to do that so if anyone want they could and just put the 3 tails are default if none custom for said tail found.

DEATHB4DEFEAT

I can probably do it in another PR (someone make an issue if this is merged without this), but we need a way to specify the cover sprites.

DEATHB4DEFEAT · 2024-06-07T04:27:39Z

Content.Shared/Clothing/EntitySystems/ClothingSystem.cs

    [ValidatePrototypeId<TagPrototype>]
    private const string HairTag = "HidesHair";

    [ValidatePrototypeId<TagPrototype>]
    private const string NoseTag = "HidesNose";

+    [ValidatePrototypeId<TagPrototype>]
+    private const string TailTag = "HidesTail";


Would be good to have this be a generic MarkingHidesLayerX.

Resources/Prototypes/Entities/Mobs/Species/base.yml

DEATHB4DEFEAT · 2024-06-07T04:31:48Z

Resources/Textures/Clothing/tailcover.rsi/meta.json

+{
+    "version": 1,
+    "license": "CC-BY-SA-4.0",
+    "copyright": "TailCover by gentlebutter (588410099190726656) and ghostprince (115894681304301569)",


Suggested change

"copyright": "TailCover by gentlebutter (588410099190726656) and ghostprince (115894681304301569)",

"copyright": "TailCover by DSC@gentlebutter (588410099190726656) and DSC@ghostprince (115894681304301569)",

github-actions · 2024-06-10T20:53:09Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: FoxxoTrystan <[email protected]>

DangerRevolution

Needs custom tail sprites as above

github-actions · 2024-07-20T04:44:17Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

FoxxoTrystan · 2024-07-23T23:43:03Z

Im going to compleatly remake this PR, Do this PR will be closed and Remade when i have the time.

FoxxoTrystan added 2 commits May 31, 2024 00:38

Init

5c8d359

The Tags!

9375282

github-actions bot added Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels May 31, 2024

FoxxoTrystan commented May 31, 2024

View reviewed changes

Resources/Prototypes/Entities/Mobs/Species/base.yml Outdated Show resolved Hide resolved

VMSolidus requested changes May 31, 2024

View reviewed changes

VMSolidus reviewed May 31, 2024

View reviewed changes

DEATHB4DEFEAT requested changes Jun 7, 2024

View reviewed changes

DEATHB4DEFEAT added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point Status: Needs Refactor Needs some system to be redone labels Jun 7, 2024

github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 10, 2024

DangerRevolution assigned FoxxoTrystan Jun 22, 2024

Merge branch 'master' into Tail-Covers

c47a4fb

Signed-off-by: FoxxoTrystan <[email protected]>

github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 10, 2024

DangerRevolution suggested changes Jul 12, 2024

View reviewed changes

FoxxoTrystan marked this pull request as draft July 13, 2024 23:48

github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 20, 2024

FoxxoTrystan closed this Jul 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tail Covers! #427

Tail Covers! #427

FoxxoTrystan commented May 31, 2024

github-actions bot commented May 31, 2024 •

edited

Loading

VMSolidus May 31, 2024

VMSolidus May 31, 2024

VMSolidus May 31, 2024

VMSolidus May 31, 2024

VMSolidus May 31, 2024

VMSolidus May 31, 2024

VMSolidus May 31, 2024

FoxxoTrystan May 31, 2024

VMSolidus May 31, 2024

PuroSlavKing commented May 31, 2024 •

edited

Loading

DEATHB4DEFEAT commented May 31, 2024

DangerRevolution commented May 31, 2024

FoxxoTrystan commented Jun 2, 2024

FoxxoTrystan commented Jun 2, 2024

DEATHB4DEFEAT left a comment

DEATHB4DEFEAT Jun 7, 2024

DEATHB4DEFEAT Jun 7, 2024

github-actions bot commented Jun 10, 2024

DangerRevolution left a comment

github-actions bot commented Jul 20, 2024

FoxxoTrystan commented Jul 23, 2024

	if ((new string[] { "outerClothing" }).Contains(args.Slot) && _tagSystem.HasTag(args.Equipee, TailTag) && _tagSystem.HasTag(args.Equipment, TailTag))
	if ((new string[] { "outerClothing" }).Contains(args.Slot) && HasComp<TailVisualComponent>(args.Equipee) && _tagSystem.HasTag(args.Equipment, TailTag))

	"copyright": "TailCover by gentlebutter (588410099190726656) and ghostprince (115894681304301569)",
	"copyright": "TailCover by DSC@gentlebutter (588410099190726656) and DSC@ghostprince (115894681304301569)",

Tail Covers! #427

Tail Covers! #427

Conversation

FoxxoTrystan commented May 31, 2024

Description

TODO

Media

Changelog

github-actions bot commented May 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PuroSlavKing commented May 31, 2024 • edited Loading

DEATHB4DEFEAT commented May 31, 2024

DangerRevolution commented May 31, 2024

FoxxoTrystan commented Jun 2, 2024

FoxxoTrystan commented Jun 2, 2024

DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 10, 2024

DangerRevolution left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2024

FoxxoTrystan commented Jul 23, 2024

github-actions bot commented May 31, 2024 •

edited

Loading

PuroSlavKing commented May 31, 2024 •

edited

Loading