Project derived navigations under nested fragments, and reject skip and take without an orderBy - #1404
Merged
Merged
Conversation
…nd take without an orderBy A fragment on a derived type below a navigation lost its navigations. The derived navigation scan ran for the root selection only, so below a navigation the field fell through to the scalar path and was dropped; the query returned null for it with no join. The scan now runs for every nested selection, and the scalar entry the selection walk had already made for the field is removed so the derived member init does not bind it twice. skip or take without an orderBy added an error and then ran the query anyway, so the response carried nondeterministic rows beside the error. The guards now throw.
SimonCropp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fragment on a derived type below a navigation lost its navigations. The derived navigation scan ran for the root selection only, so below a navigation the field fell through to the scalar path and was dropped; the query returned null for it with no join. The scan now runs for every nested selection, and the scalar entry the selection walk had already made for the field is removed so the derived member init does not bind it twice.
skip or take without an orderBy added an error and then ran the query anyway, so the response carried nondeterministic rows beside the error. The guards now throw.