Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross axis alignment for title and description. #469

Conversation

binSaed
Copy link

@binSaed binSaed commented Aug 19, 2024

Description

add support to change CrossAxisAlignment for the title and description
no braking changes

titleDesCrossAxisAlignment: CrossAxisAlignment.center,
Screenshot 2024-08-19 at 5 52 45 AM

without titleDesCrossAxisAlignment
Screenshot 2024-08-19 at 5 53 00 AM

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@aditya-css
Copy link
Collaborator

Hello @binSaed,
Thanks for your contribution, but you can achieve this exact behaviour using descriptionAlignment and titleAlignment properties.

There is also PR #459 already open to further fix the code related to this.

@aditya-css aditya-css closed this Sep 7, 2024
@binSaed
Copy link
Author

binSaed commented Sep 7, 2024

@aditya-css
Thanks for your replay
But for your information descriptionAlignment and titleAlignment are text-align and only work if the text width is more than the showCase width
I hope you try to make the same result with the current implementation

Screenshot 2024-08-19 at 5 52 45 AM

@aditya-css
Copy link
Collaborator

Yes @binSaed, you are correct and we noticed that and have created PR #459 that renames the current properties to appropriate name suggesting it is TextAlign and added new properties for cross axis alignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants