Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rasa Entities Role and Groups #52

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open

Conversation

tomgun132
Copy link

As discussed in #48
List of added functionalities:

  • Entities Roles and Groups with chatette annotation format. For example
I want to go from @[place]("role": "departure", "group": "airport") to @[place]("role": "arrival")

@Bohemus307
Copy link

Bohemus307 commented Jul 1, 2021

Any chance for a Yml adapter soon? It would be a great feature!!

@SimGus
Copy link
Owner

SimGus commented Jul 1, 2021

Hello @tomgun132, thanks a lot for your changes!
I'll review them as soon as I can and let you know if any changes are required

@SimGus
Copy link
Owner

SimGus commented Jul 1, 2021

Hi @Bohemus307!

Since yaml is a superset of json, the json adapter can actually be considered a yaml adapter (which is the reason I never made a "proper" one). However, if you think it would make sense to create a proper one and want to discuss it further, you can open an issue about this :)

Cheers!

@Bohemus307
Copy link

I wasnt aware of that thank you SimGus. I haven't tried to use the JSON in rasa yet do I just add it to the nlu directory or do I need to add it to the config as a custom directory?

@SimGus
Copy link
Owner

SimGus commented Jul 1, 2021

It's been a while I haven't used Rasa, but unless they changed something you should be able to simply add the generated file to the nlu directory

@tomgun132
Copy link
Author

tomgun132 commented Jul 2, 2021

Hi @Bohemus307 @SimGus
Yaml adapter is already included in this PR and should've been implemented if this PR is approved.
Meanwhile, you can try it from my forked repository first and if you find some bugs or suggestion, please report it here :)

And also, yeah, you can put JSON file inside the NLU folder in your rasa training data directory and when you train, Rasa can detect whether the JSON format is the correct training data format or not. Though, it's easier to for human to read a yaml file than a json file.

@tomgun132
Copy link
Author

hi @SimGus, do you have any update on this?
Sorry to interrupt if you're currently busy with your main work.

@Atorpat
Copy link

Atorpat commented Aug 9, 2022

Hey @tomgun132,

Any update on this branch? I really would like to use roles and groups with chatette, but it seems the option is not available yet.

@tomgun132
Copy link
Author

Hi @Atorpat
Roles and groups can already be used from my forked master branch with:

I want to go from @[place]("role": "departure", "group": "airport") to @[place]("role": "arrival")

It will generate something like:

- I want to go from [Berlin]{"entity": "place", "role": "departure", "group": "airport"} to [San Francisco]{"entity": "place", "role": "arrival"}.

I haven't used Rasa in a while since my project has changed but I think the format hasn't changed that much so you can still use it as it is.

@Atorpat
Copy link

Atorpat commented Aug 10, 2022

@tomgun132

Thanks a lot, Tom. yes, the format is still the same.
I will try the branch. It's a shame we don't have it on the main project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants