Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45: ZPC Poller Fix #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

silabs-borisl
Copy link
Collaborator

@silabs-borisl silabs-borisl commented May 2, 2024

Change

Fix initialization of Z-Wave attribute poller, so it can work as intended

Related community question : https://community.silabs.com/s/question/0D7Vm000001kTeLKAU/detail?language=en_US

Checklist

const DOTDOT_ATTRIBUTE_ID_STATE_NETWORK_STATUS: AttributeTypeId = 0x000D;
const ZCL_NODE_STATE_NETWORK_STATUS_ONLINE_FUNCTIONAL: u8 = 1;
const DOTDOT_ATTRIBUTE_ID_STATE_NETWORK_STATUS: AttributeTypeId = 0xfd020001;
// This is reported as a u32 in the attribute store
Copy link
Collaborator

@rzr rzr May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what makes you think that there bug is not elsewhere ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand your question. I've added the community post for more context in the PR

Copy link
Collaborator

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work but is this optimal ?

Copy link
Collaborator

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may you also cross link context in commit message

silabs-borisl added a commit to silabs-borisl/UnifySDK that referenced this pull request May 3, 2024
Forwarded: SiliconLabs#45
Bug-SiliconLabs: UIC-2964
Bug-Github: SiliconLabs#45
@silabs-borisl silabs-borisl force-pushed the GH-45/UIC-2964-poller-fix branch from 93a187f to 67577b0 Compare May 3, 2024 08:31
@silabs-borisl
Copy link
Collaborator Author

this should work but is this optimal ?

Ideally, we should have ZAP generating this for Rust components but I think at this time we'll invest a lot of time for not much gain.

Forwarded: SiliconLabs#45
Bug-SiliconLabs: UIC-2964
Bug-Github: SiliconLabs#45
@silabs-borisl silabs-borisl force-pushed the GH-45/UIC-2964-poller-fix branch from 67577b0 to e244c51 Compare May 16, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants