Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35: Control over Size & Precision in Thermostat Setpoint CC #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

silabs-borisl
Copy link
Collaborator

@silabs-borisl silabs-borisl commented Mar 11, 2024

⚠️ CAUTION

This PR modify existing attributes ID and .uam files. To test it do the following :

  • Start with a fresh database or exclude and include your thermostat(s)
    • Default database location : /var/lib/uic/zpc.db
  • Update the uam files :
    • In the Unify folder sudo cp applications/zpc/components/dotdot_mapper/rules/* /usr/share/uic/rules/

In case of errors/unexpected behavior :

  • Start ZPC with the following options and share the full log :
    • zpc --log.tag_level zwave_command_class_thermostat_setpoint:d,attribute_store:d
  • Provide the full attribute store log.
    • Within zpc : ZPC> attribute_store_log
  • Attach Zniffer log with decryption keys if applicable
    • Within zpc : ZPC> zwave_log_security_keys

New features :

  • Added consistency in precision. UCL precision is now always 2 and Z-Wave tries to adapt.
  • Precision has now its own attribute
  • Size is automatically determined based on value size

Forwarded: #36
Bug-SiliconLabs: UIC-3320
Bug-Github: #36

…t CC

- Precision has now its own attribute
- Size is automatically determined based on value size

Forwarded: SiliconLabs#34
Bug-SiliconLabs: UIC-3320
Bug-Github: SiliconLabs#34
silabs-borisl added a commit to silabs-borisl/UnifySDK that referenced this pull request Mar 12, 2024
… with a flag

A new flag have been introduced to send the endpoint Generic/Specific class in multi_channel_endpoint_find.

The default behavior is to send 0xFF to discover all endpoints.

Forwarded: SiliconLabs#36
Bug-SiliconLabs: UIC-3160
Bug-Github: SiliconLabs#36
@miline
Copy link

miline commented Mar 19, 2024

Is the precision attribute also exposed to MQTT now?

@silabs-borisl
Copy link
Collaborator Author

For now it is not exposed to MQTT.
I'm working on this PR right now to fix some more issues concerning the precision type.

Are you interested in having this attribute exposed ?

UCL precision is now always 2 whild Zwave is trying to adapt to the UCL precision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants