-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dependabot.yml and Docker Container Build and release workflow #7
Open
8ear
wants to merge
21
commits into
SigmaHQ:main
Choose a base branch
from
8ear:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to fix Issue
Fix issues for tags
Test env substituion
Fix env for github repo name
Rename Workflow
Fix env variables
Add Set up qumu step
Fix RUN issue
Add non-priv user
Fix user add lines
Change from pipx to pip
Cool 👍 Thanks a lot for the contribution! I see some further setup in the repo is required, I will do this when I find some time. |
@8ear would probably be better to build from source and use multi-stage to keep the file size down as much as possible Here's one I was gonna submit but found your PR FROM python:3-slim as poetry
ENV POETRY_HOME=/opt/poetry
ENV POETRY_VIRTUALENVS_IN_PROJECT=true
ENV PATH="$POETRY_HOME/bin:$PATH"
WORKDIR /app
# Install Poetry
RUN python -c 'from urllib.request import urlopen; print(urlopen("https://install.python-poetry.org").read().decode())' | python -
# Copy pyproject.toml
COPY pyproject.toml pyproject.toml
COPY poetry.lock poetry.lock
# Install packages
RUN pip3 install --upgrade pip
RUN poetry install --only main --no-interaction --no-ansi --no-root -vvv
# Install sigma-cli
COPY ./ ./
RUN rm -r .github/ .git/
RUN poetry install --only main --no-interaction --no-ansi -vvv
# Copy Artifacts to clean image
FROM python:3.11-alpine as runtime
WORKDIR /app
ENV PATH="/app/.venv/bin:$PATH"
ENV PYTHONPATH "${PYTHONPATH}:/app:/app/.venv/lib/python3.11/site-packages/"
# Copy sigma-cli over
COPY --from=poetry /app /app
ENTRYPOINT ["sigma"]
CMD ["--help"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I like your python tool very much. But I not so a big fan of installing python stuff all the time directly on my machine. Therefore I created a Dockerfile to create a docker container from your content and include directly a Github workflow so that the container is build automatically to the github repository.
Please check out the stuff.
Kind regards
Max