Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: correct id generation for log timestamp #376

Merged
merged 2 commits into from
Aug 30, 2024
Merged

feat: correct id generation for log timestamp #376

merged 2 commits into from
Aug 30, 2024

Conversation

nityanandagohain
Copy link
Member

NewRandomWithTime fixes the current issues that we have with id's

  • Ids will now respect the timestamp of the log line regardless of when it is ingested.
  • During collision of timestamp the randomness of 16 bits will make sure that there is no collision between logs of same timestamp. ( probability is one in billion)

@nityanandagohain nityanandagohain merged commit 47e8ae2 into main Aug 30, 2024
3 checks passed
@srikanthccv srikanthccv deleted the issue_5614 branch August 30, 2024 09:20
@nityanandagohain nityanandagohain mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan ankitnayan is a code owner

@makeavish makeavish Awaiting requested review from makeavish makeavish is a code owner

@prashant-shahi prashant-shahi Awaiting requested review from prashant-shahi prashant-shahi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nityanandagohain @srikanthccv