-
Notifications
You must be signed in to change notification settings - Fork 36
Implemented read-out of trace files for custom sample lengths #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gafderks
wants to merge
13
commits into
SideChannelMarvels:master
Choose a base branch
from
gafderks:word_length
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dad17e5
Added word_length variable to configuration
3fea7a7
Added word_length variable to configuration
8b680f0
Added word_length variable to configuration
0844312
Merge branch 'word_length' of github.com:gafderks/Daredevil into word…
gafderks 278986e
Implemented usage of word_length setting
gafderks 17bf8f9
Merge branch 'word_length' of https://github.com/gafderks/Daredevil i…
gafderks 2434975
Merge branch 'word_length' of github.com:gafderks/Daredevil into word…
gafderks 12e1391
Fixed compilation errors
gafderks 135c1ce
Fixed compilation errors
gafderks 95c0b24
Merge branch 'word_length' of github.com:gafderks/Daredevil into word…
gafderks 546acc0
Fixed type issues in configuration parsing
gafderks 5fdbe31
Moved printing of word length in config to a better location
gafderks c3705a9
Use word_length for allocating the Matrix for traces
gafderks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -435,6 +435,14 @@ struct Config { | |
| * -1 = all | ||
| */ | ||
| int8_t bitnum; | ||
|
|
||
| /* The number of bits that we want to consider as a word for the traces. | ||
| * The number of samples in n_samples must not be altered upon changing the word length | ||
| * in the configuration file since this is already accounted for. | ||
| * | ||
| * "default" = use type_trace defined length | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. => use "trace_type" |
||
| */ | ||
| int word_length; | ||
|
|
||
| }; | ||
|
|
||
|
|
@@ -520,7 +528,7 @@ size_t fload(const char str[], Type *** mem, int chunk_size, long int chunk_offs | |
| /* Like load_file but doens't allocate new memory each time. | ||
| */ | ||
| template <class Type> | ||
| int load_file_v_1(const char str[], Type *** mem, int n_rows, int n_columns, long int offset, int total_n_columns); | ||
| int load_file_v_1(const char str[], Type *** mem, int n_rows, int n_columns, long int offset, int total_n_columns, int word_length); | ||
|
|
||
| /* Loads the file located at str in the 2D array mem, whose dimensions | ||
| * are specified by n_rows and n_columns | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in some weird cases (trace_type=d, word_length=...) the sample will be 64b.
So "int" is too small for sample.