Skip to content

Commit

Permalink
fixes for req routing
Browse files Browse the repository at this point in the history
  • Loading branch information
@Sidd-77
Sidd-77 committed Jan 2, 2025
1 parent 0eba2fa commit 9910e1d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions apps/web/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ RUN npm ci

COPY . .

ENV VITE_AUTH_URL="http://auth-service:4000" \
VITE_DB_URL="http://db-service:4100" \
VITE_SOCKET_URL="http://socket-service:4200" \
VITE_FILE_URL="http://file-service:4300" \
VITE_NOTIFICATION_URL="http://notification-service:4400" \
ENV VITE_AUTH_URL="messagepunk.com" \

Check warning on line 14 in apps/web/Dockerfile

View workflow job for this annotation

GitHub Actions / Build and Publish Docker Image of Web App

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$VITE_VAPID_PUBLIC_KEY'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 14 in apps/web/Dockerfile

View workflow job for this annotation

GitHub Actions / Build and Publish Docker Image of Web App

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "VITE_AUTH_URL")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
VITE_DB_URL="messagepunk.com" \
VITE_SOCKET_URL="messagepunk.com" \
VITE_FILE_URL="messagepunk.com" \
VITE_NOTIFICATION_URL="messagepunk.com" \
VITE_VAPID_PUBLIC_KEY=${VITE_VAPID_PUBLIC_KEY}

WORKDIR /app/packages/models
Expand Down

0 comments on commit 9910e1d

Please sign in to comment.