Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EBeam_GC_SiN_1310_8deg.py #292

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

Hang-Bobby-Zou
Copy link
Contributor

Added an adapted PCell for OBand GC

Added an adapted PCell for OBand GC
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.68473% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (0db1171) to head (8486160).

Files Patch % Lines
...Beam/pymacros/pcells_SiN/EBeam_GC_SiN_1310_8deg.py 87.68% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   73.00%   73.26%   +0.25%     
==========================================
  Files          93       94       +1     
  Lines       11284    11487     +203     
==========================================
+ Hits         8238     8416     +178     
- Misses       3046     3071      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasc-ubc
Copy link
Member

Hi Bobby,

  1. numpy is now part of KLayout, so we should just use that.
  2. we have a function make_pin, can you use that instead?
  3. have you verified the cell using simulation and/or fabrication?
  4. does this cell only work for 1.31 µm, or could it be used for other wavelengths, say 900, 1550, etc?

from SiEPIC.utils.layout import make_pin

def make_pin(cell, name, center, w, layer, direction, debug=False):
    '''
    Makes a pin that SiEPIC-Tools will recognize
    cell: which cell to draw it in
    name: text label for the pin
    center: location, int [x,y]
    w: pin width
    layer: layout.layer() integer type, or string
    direction = 
        0: right
        90: up
        180: left
        270: down

    Units: input can be float for microns, or int for database units (typ. nm)
    '''

@lukasc-ubc lukasc-ubc merged commit ada3345 into SiEPIC:master Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants