-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates localized field hooks in Unstable
#2559
base: unstable
Are you sure you want to change the base?
Conversation
/snapit |
🫰✨ Thanks @rcaplanshopify! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions-react": "0.0.0-snapshot-20250108190357" |
933408a
to
6c51c6a
Compare
/snapit |
🫰✨ Thanks @rcaplanshopify! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions-react": "0.0.0-snapshot-20250114215839" |
/snapit |
🫰✨ Thanks @rcaplanshopify! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions-react": "0.0.0-snapshot-20250114231812" |
40d9896
to
243e14f
Compare
243e14f
to
b42540d
Compare
Unstable
@@ -62,7 +62,7 @@ export interface Extension<Target extends ExtensionTarget = ExtensionTarget> { | |||
/** | |||
* The API version that was set in the extension config file. | |||
* | |||
* @example '2024-04', '2024-07', '2024-10', '2025-01', 'unstable' | |||
* @example '2024-07', '2024-10', '2025-01', '2025-04', 'unstable' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to add this yet. It's not a valid version yet so could be a little misleading. Usually we add this days before publishing.
packages/ui-extensions/src/shared.ts
Outdated
@@ -917,6 +918,7 @@ export type StorefrontApiVersion = | |||
| '2024-07' | |||
| '2024-10' | |||
| '2025-01' | |||
| '2025-04' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to add this yet. It's not a valid version yet so could be a little misleading. Usually we add this days before publishing.
packages/ui-extensions/src/shared.ts
Outdated
@@ -24,6 +24,7 @@ export type ApiVersion = | |||
| '2024-07' | |||
| '2024-10' | |||
| '2025-01' | |||
| '2025-04' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to add this yet. It's not a valid version yet so could be a little misleading. Usually we add this days before publishing.
{ | ||
title: 'useLocalizedField', | ||
description: | ||
'Returns the current localized fields and re-renders your component if the values change.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Returns the current localized fields and re-renders your component if the values change.', | |
'Returns the requested localized field and re-renders your component if the value changes.', |
512608b
to
2ed23b7
Compare
Background
This PR optimizes the
useLocalizedFields
hook and introduces theuseLocalizedField
hook. It also updates the related docs.Solution
(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)
🎩
Unstable localized field API docs
Checklist