Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLM instructions file suggestion #669

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d85fb01
wip
karreiro Dec 11, 2024
d28aecd
(wip 2) calling the language model api
karreiro Dec 11, 2024
a7ea901
(wip 3) sidefix
karreiro Dec 11, 2024
de43c0d
Add LLM instructions file suggestion
madmath Dec 11, 2024
228e7e5
(wip 4) make sidekick a bit less ugly
karreiro Dec 11, 2024
ffba964
(wip 5) make sidekick a bit less ugly (2)
karreiro Dec 11, 2024
9fec1ad
Move loading state to title button (#670)
frandiox Dec 12, 2024
e08c539
Support multiple suggestions from a single request (#671)
frandiox Dec 12, 2024
3873d08
Bring hover back
karreiro Dec 12, 2024
1320bbe
Support suggestions on selected code (#672)
frandiox Dec 12, 2024
56ef14f
Hide suggestions on code change (#673)
frandiox Dec 12, 2024
81ad912
update llm instructions
madmath Dec 11, 2024
d12bc9d
(wip) updated prompt
karreiro Dec 12, 2024
f2619da
(wip) prompt
karreiro Dec 12, 2024
904feb9
(wip) prompt 2
karreiro Dec 12, 2024
dfeb4c5
Add LLM instructions file suggestion
madmath Dec 11, 2024
8a1a11a
update llm instructions
madmath Dec 11, 2024
1e3509b
New llm instruction file
benjaminsehl Dec 12, 2024
0adc2a6
Merge branch 'llm-instructions-file' into sehl/llm-instructions-file
benjaminsehl Dec 12, 2024
7aa2d06
Merge pull request #675 from Shopify/sehl/llm-instructions-file
madmath Dec 12, 2024
5df43b3
Use diff view for sidefix
frandiox Dec 13, 2024
92c6643
Improve the timing for removing suggestions
frandiox Dec 13, 2024
f1074e8
Try to improve the prompt
frandiox Dec 13, 2024
a38a8cb
Update prompt to use tag convention
karreiro Dec 13, 2024
f816e2b
Remove duplicated functions; extract file creation to a method because
karreiro Dec 13, 2024
bdd6da0
Fine tuning prompt
karreiro Dec 13, 2024
6d0cf71
Remove unused items
karreiro Dec 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
} from '@shopify/theme-check-common';
import {
Connection,
DocumentSelector,
FileOperationRegistrationOptions,
InitializeResult,
ShowDocumentRequest,
Expand Down Expand Up @@ -268,6 +269,7 @@ export function startServer(
save: true,
openClose: true,
},
inlineCompletionProvider: true, // only available in 3.18 (not released yet)
codeActionProvider: {
codeActionKinds: [...CodeActionKinds],
},
Expand Down Expand Up @@ -305,7 +307,7 @@ export function startServer(
name: 'theme-language-server',
version: VERSION,
},
};
} as InitializeResult;

return result;
});
Expand Down
28 changes: 28 additions & 0 deletions packages/vscode-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,36 @@
{
"command": "shopifyLiquid.runChecks",
"title": "Liquid Theme Check: Run Checks"
},
{
"command": "shopifyLiquid.sidefix",
"title": "Apply Sidekick suggestion"
},
{
"command": "shopifyLiquid.sidekick",
"title": "✨ Sidekick",
"enablement": "!shopifyLiquid.sidekick.isLoading"
},
{
"command": "shopifyLiquid.sidekickLoading",
"title": "✨ Analyzing",
"enablement": "false"
}
],
"menus": {
"editor/title": [
{
"command": "shopifyLiquid.sidekick",
"group": "navigation",
"when": "!shopifyLiquid.sidekick.isLoading"
},
{
"command": "shopifyLiquid.sidekickLoading",
"group": "navigation",
"when": "shopifyLiquid.sidekick.isLoading"
}
]
},
"configuration": {
"title": "Shopify Liquid | Syntax Highlighting & Linter by Shopify",
"properties": {
Expand Down
Loading
Loading