Add shopify_system_translations.json to theme-tools
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
changed the title
theme-liquid-docs [...] shopify_system_translations.json to theme-toolsshopify_system_translations.json to theme-tools
charlespwd
reviewed
Nov 16, 2023
charlespwd
reviewed
Nov 16, 2023
packages/theme-check-docs-updater/src/themeLiquidDocsManager.spec.ts
Outdated
Show resolved
Hide resolved
charlespwd
reviewed
Nov 16, 2023
packages/theme-check-docs-updater/src/themeLiquidDocsManager.ts
Outdated
Show resolved
Hide resolved
charlespwd
reviewed
Nov 16, 2023
packages/theme-language-server-common/src/server/startServer.ts
Outdated
Show resolved
Hide resolved
charlespwd
approved these changes
Nov 16, 2023
…pec.ts Co-authored-by: CP Clermont <[email protected]>
Co-authored-by: CP Clermont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
In this PR introduces the
shopify_system_translations.jsonfile, from Shopify/theme-liquid-docs. It's always auto-updated, so we no longer need theshopify-translation-keys.jsonfile.Now, the
translation-key-existscheck will always be up-to-date, and intelligent code completion suggests Shopify translation keys:Before you deploy
changesetFixes #167