Add support for HTML node name linked editing, highlighting and renaming #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
force-pushed
the
fix/241-html-node-rename-goodness
branch
from
e7cfd2e to
99507ca
Compare
Edit both the open and close tags at the same time... it's magical :D
- LiquidTagName highlight provider (if/endif, form/endform, etc.) - HtmlTagName highlight provider (<main></main>, etc.)
charlespwd
force-pushed
the
fix/241-html-node-rename-goodness
branch
3 times, most recently
from
0190b06 to
9e38ca1
Compare
F2 to rename an HTML open/close pair.
Let's prevent folks from trying to rename things you can't really rename.
Let's also give the right placeholder for complex contexts
e.g. the placeholder for the rename should be the compound name
`product--{{ type }}` for the HTML element with a liquid name.
```
<product-{{ type }}></product--{{ type }}>
```
charlespwd
force-pushed
the
fix/241-html-node-rename-goodness
branch
from
9e38ca1 to
246db8c
Compare
|
I'm closing this PR. It's getting too big. I'll split it up and make it easier to digest. I'll also use this opportunity to document what I'm doing more for folks to onboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
(WIP)
linked-editing.mp4
Fixes #241
What did you learn?
Before you deploy
changesetallChecksarray insrc/checks/index.tsyarn update-configsand committed the updated configuration filestheme-app-extension.ymlconfigchangesetchangeset