Add LLM instructions file suggestion #669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmath
force-pushed
the
llm-instructions-file
branch
2 times, most recently
from
a7f5b8b to
81ad912
Compare
the early return was preventing the language server initialization when the instrunction file was already there
karreiro
force-pushed
the
llm-instructions-file
branch
2 times, most recently
from
1edad8c to
288f786
Compare
… editor decorations'
…lm-instructions.ts' + unit tests - Add 'getShopifyThemeRootDirs' and 'fileExists' APIs
- Adjust prompt and similarity - Test Shopify Magic
karreiro
approved these changes
Jan 28, 2025
|
👋 Hey @charlespwd @frandiox, this PR is ready for review now :) |
frandiox
reviewed
Jan 30, 2025
frandiox
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Finally able to test it, great job 🎉
I've tried to close the hover without much luck either!
While testing, I found a few minor things:
- I got into this situation a couple of times when applying one suggestion after another. cmd+z and click again fixes the situation... no idea why it happens in the first place :/
- I saw you added a comment to avoid the "Keep xyz when is already valid"... however this still happens often:
Should we maybe compare the suggestion with the code-to-be-replaced and skip it if it's the same? 🤔
- Not important but do we rename
sidefixto something else?
|
Thank you for the review, @frandiox! I've applied the suggestions :) also, I've created this to handle scenario 1, slightly updated the prompt to prevent the scenario 2 (I couldn't get those "Keep <suggestion...>" anymore in my theme), and I've renamed Thanks again for the review! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
This PR introduces support for:
.cursorrules/copilot-instructions.mdwhich works with multiple themes opened in the same workspace.cursorrules/copilot-instructions.mdfiles are generated based on https://github.com/Shopify/theme-liquid-docsClick here to check a demo of this feature.
What's next? Any follow-up issues?
After clicking on “Quick fix,” close the hover dialog automatically (so users may see the suggestions immediately) — I don't think that's possible, but I'm planning to revisit this when we get this work on main.
Before you deploy
changeset