Refactor Liquid documentation types and update references to improve … #1861
jamesmengoAnnotations
11 errors and 2 warnings
|
packages/theme-language-server-common/src/liquidDoc.spec.ts > Unit: makeGetLiquidDocDefinitions > should return name if no valid annotations are present in definition:
packages/theme-language-server-common/src/liquidDoc.spec.ts#L21
AssertionError: expected { name: 'product-card', …(1) } to deeply equal { Object (name, parameters) }
- Expected
+ Received
Object {
- "name": "product-card",
+ "liquidDoc": Object {
"parameters": Array [],
+ },
+ "name": "product-card",
}
❯ packages/theme-language-server-common/src/liquidDoc.spec.ts:21:28
|
|
packages/theme-language-server-common/src/liquidDoc.spec.ts > Unit: makeGetLiquidDocDefinitions > should extract name, description and type from param annotations:
packages/theme-language-server-common/src/liquidDoc.spec.ts#L38
AssertionError: expected { name: 'product-card', …(1) } to deeply equal { name: 'product-card', …(1) }
- Expected
+ Received
Object {
- "name": "product-card",
+ "liquidDoc": Object {
"parameters": Array [
Object {
"description": "The first param",
"name": "firstParam",
"type": "String",
},
Object {
"description": "The second param",
"name": "secondParam",
"type": "Number",
},
Object {
"description": "param with no type",
"name": "paramWithNoType",
"type": null,
},
Object {
"description": "",
"name": "paramWithOnlyName",
"type": null,
},
],
+ },
+ "name": "product-card",
}
❯ packages/theme-language-server-common/src/liquidDoc.spec.ts:38:28
|
|
Tests / OS ubuntu-latest / NodeJS 20
Process completed with exit code 1.
|
|
Tests / OS windows-latest / NodeJS 20
The job was canceled because "ubuntu-latest_20" failed.
|
|
Tests / OS windows-latest / NodeJS 20
The operation was canceled.
|
|
Tests / OS windows-latest / NodeJS 18
The job was canceled because "ubuntu-latest_20" failed.
|
|
Tests / OS windows-latest / NodeJS 18
The operation was canceled.
|
|
Tests / OS ubuntu-latest / NodeJS 18
The job was canceled because "ubuntu-latest_20" failed.
|
|
packages/theme-language-server-common/src/liquidDoc.spec.ts > Unit: makeGetLiquidDocDefinitions > should return name if no valid annotations are present in definition:
packages/theme-language-server-common/src/liquidDoc.spec.ts#L21
AssertionError: expected { name: 'product-card', …(1) } to deeply equal { Object (name, parameters) }
- Expected
+ Received
Object {
- "name": "product-card",
+ "liquidDoc": Object {
"parameters": Array [],
+ },
+ "name": "product-card",
}
❯ packages/theme-language-server-common/src/liquidDoc.spec.ts:21:28
|
|
packages/theme-language-server-common/src/liquidDoc.spec.ts > Unit: makeGetLiquidDocDefinitions > should extract name, description and type from param annotations:
packages/theme-language-server-common/src/liquidDoc.spec.ts#L38
AssertionError: expected { name: 'product-card', …(1) } to deeply equal { name: 'product-card', …(1) }
- Expected
+ Received
Object {
- "name": "product-card",
+ "liquidDoc": Object {
"parameters": Array [
Object {
"description": "The first param",
"name": "firstParam",
"type": "String",
},
Object {
"description": "The second param",
"name": "secondParam",
"type": "Number",
},
Object {
"description": "param with no type",
"name": "paramWithNoType",
"type": null,
},
Object {
"description": "",
"name": "paramWithOnlyName",
"type": null,
},
],
+ },
+ "name": "product-card",
}
❯ packages/theme-language-server-common/src/liquidDoc.spec.ts:38:28
|
|
Tests / OS ubuntu-latest / NodeJS 18
The operation was canceled.
|
|
Tests / OS ubuntu-latest / NodeJS 20
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Code quality
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|