Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotations for PR, Prettier, and more #50

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

andershagbard
Copy link
Contributor

@andershagbard andershagbard commented Nov 13, 2024

This PR has a few changes

src/addAnnotations.ts

  • Make the sha the sha for the PR, and not the commit. This makes the annotations show up in "Files changed"
  • Made sure the annotation.path is relative to GitHub, and not the --path value
  • Made type GitHubAnnotation come from rest endpoint
  • Removed redundant as Type in various places
  • Made some functions more readable, and placed them "correctly"
  • Use spread for ...ctx.repo

General

  • Updated all packages to latest compatible versions
  • Added prettier and ran prettier

@andershagbard
Copy link
Contributor Author

We may also consider marking the job as completed and succeeded if using a token, as annotations will show up as an error.

Ignore the jobs in the middle, this is mixed with my other actions.

image

@andershagbard andershagbard marked this pull request as ready for review November 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant