-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for add-on #2108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/add-test-app
branch
2 times, most recently
from
December 5, 2024 19:54
731b94a
to
1272fc7
Compare
andyw8
force-pushed
the
andyw8/add-test-app
branch
2 times, most recently
from
December 10, 2024 17:04
13e7fb1
to
c430822
Compare
andyw8
commented
Dec 10, 2024
andyw8
commented
Dec 10, 2024
andyw8
force-pushed
the
andyw8/add-test-app
branch
3 times, most recently
from
December 16, 2024 16:58
1341238
to
f73556c
Compare
andyw8
changed the title
WIP: Add integration tests for addon
Add integration tests for addon
Dec 16, 2024
andyw8
commented
Dec 16, 2024
andyw8
changed the title
Add integration tests for addon
Add integration tests for add-on
Dec 16, 2024
Looking into the test failures, seems unrelated to this PR though:
|
andyw8
force-pushed
the
andyw8/add-test-app
branch
from
December 17, 2024 19:08
ac043a9
to
7cfa93a
Compare
andyw8
commented
Dec 17, 2024
KaanOzkan
reviewed
Dec 17, 2024
KaanOzkan
reviewed
Dec 18, 2024
KaanOzkan
reviewed
Dec 18, 2024
|
andyw8
force-pushed
the
andyw8/add-test-app
branch
from
December 19, 2024 18:58
30963aa
to
9cfb25c
Compare
KaanOzkan
reviewed
Jan 2, 2025
vinistock
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a job, but it's under app/models
. Is that intentional?
andyw8
force-pushed
the
andyw8/add-test-app
branch
from
January 8, 2025 14:53
3e41f5f
to
6fcd4b9
Compare
@vinistock everything should have been addressed now. |
vinistock
approved these changes
Jan 8, 2025
andyw8
force-pushed
the
andyw8/add-test-app
branch
from
January 8, 2025 17:38
ae00022
to
336e04d
Compare
(squashed) |
andyw8
force-pushed
the
andyw8/add-test-app
branch
from
January 8, 2025 18:57
d2135b0
to
336e04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Shopify/team-ruby-dx/issues/1327
This PR adds an integration test for the flow of generating DSL RBIs for a particular compiler.
I chose to use the ActiveJob compiler to avoid any database complexity.
I've tried to reduce the Rails files to the minimum possible.