Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for add-on #2108

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add integration tests for add-on #2108

merged 1 commit into from
Jan 8, 2025

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Dec 3, 2024

Closes https://github.com/Shopify/team-ruby-dx/issues/1327

This PR adds an integration test for the flow of generating DSL RBIs for a particular compiler.

I chose to use the ActiveJob compiler to avoid any database complexity.

I've tried to reduce the Rails files to the minimum possible.

@andyw8 andyw8 force-pushed the andyw8/add-test-app branch 2 times, most recently from 731b94a to 1272fc7 Compare December 5, 2024 19:54
@andyw8 andyw8 added the chore label Dec 5, 2024
@andyw8 andyw8 force-pushed the andyw8/add-test-app branch 2 times, most recently from 13e7fb1 to c430822 Compare December 10, 2024 17:04
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@andyw8 andyw8 force-pushed the andyw8/add-test-app branch 3 times, most recently from 1341238 to f73556c Compare December 16, 2024 16:58
@andyw8 andyw8 changed the title WIP: Add integration tests for addon Add integration tests for addon Dec 16, 2024
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
@andyw8 andyw8 changed the title Add integration tests for addon Add integration tests for add-on Dec 16, 2024
@andyw8 andyw8 marked this pull request as ready for review December 16, 2024 17:18
@andyw8 andyw8 requested a review from a team as a code owner December 16, 2024 17:18
@andyw8 andyw8 requested a review from KaanOzkan December 16, 2024 17:18
@andyw8
Copy link
Contributor Author

andyw8 commented Dec 17, 2024

Looking into the test failures, seems unrelated to this PR though:

    it compile RBIs with location from gem source                   FAIL (1.20s)
        --- expected
        +++ actual
        @@ -1,66 +1,66 @@
        -"# source://the-default-gem//lib/bar.rb#1
        +"# source://the-default-gem/lib/bar.rb#1

spec/addon_spec_helper.rb Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
spec/addon_spec_helper.rb Outdated Show resolved Hide resolved
spec/addon_spec_helper.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
@andyw8
Copy link
Contributor Author

andyw8 commented Dec 18, 2024

(I will squash before merging).
DONE

@andyw8 andyw8 force-pushed the andyw8/add-test-app branch from 30963aa to 9cfb25c Compare December 19, 2024 18:58
spec/addon_spec_helper.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a job, but it's under app/models. Is that intentional?

spec/tapioca/addon_spec.rb Show resolved Hide resolved
spec/tapioca/addon_spec.rb Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
@andyw8 andyw8 force-pushed the andyw8/add-test-app branch from 3e41f5f to 6fcd4b9 Compare January 8, 2025 14:53
@andyw8
Copy link
Contributor Author

andyw8 commented Jan 8, 2025

@vinistock everything should have been addressed now.

@andyw8 andyw8 force-pushed the andyw8/add-test-app branch from ae00022 to 336e04d Compare January 8, 2025 17:38
@andyw8
Copy link
Contributor Author

andyw8 commented Jan 8, 2025

(squashed)

@andyw8 andyw8 enabled auto-merge January 8, 2025 17:59
@andyw8 andyw8 force-pushed the andyw8/add-test-app branch from d2135b0 to 336e04d Compare January 8, 2025 18:57
@andyw8 andyw8 merged commit 474cb62 into main Jan 8, 2025
65 of 67 checks passed
@andyw8 andyw8 deleted the andyw8/add-test-app branch January 8, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants