Adding indifferent access #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sle-c
reviewed
Apr 9, 2024
lib/shopify_api/rest/base.rb
Outdated
| @@ -2,6 +2,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require "active_support/inflector" | |||
| require 'active_support/all' | |||
There was a problem hiding this comment.
We should explicitly require hash_with_indifferent_access from active_support and not all
There was a problem hiding this comment.
Okay, this makes sense. Thanks!
|
@elizasorber , could you sign the CLA https://cla.shopify.com/ and comment "I have signed the CLA!"? |
|
I have signed the CLA! |
|
@sle-c Hi! Do I need to write tests or a changelog entry to get this issue approved and merged? |
|
hey @elizasorber , yeah we need a changelog entry and also change the import from |
|
there's a rubocop rule that we need to fix as well as rebase on the main branch :) |
…ces_from_response in the ShopifyAPI::Rest::Base class.
sle-c
force-pushed
the
adding_indifferent_access_issue_1296
branch
from
437594c
to
359d9ba
Compare
lizkenyon
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackling issue #1296 Added indifferent access to create_instances_from_response in the ShopifyAPI::Rest::Base class.
Description
Fixes #
Please, include a summary of what the PR is for:
How has this been tested?
Please, describe the tests that you ran to verify your changes.
Checklist: