Force-enable host-based circuits #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkipper
force-pushed
the
mkipper/global-circuit-breaker-simple-integer
branch
from
5a83daf to
c2721ba
Compare
thegedge
reviewed
Jul 2, 2019
michaelkipper
force-pushed
the
mkipper/global-circuit-breaker-simple-integer
branch
from
7a73849 to
926074d
Compare
thegedge
approved these changes
Jul 3, 2019
thegedge
left a comment
thegedge
left a comment
There was a problem hiding this comment.
Seems like the most sane way to roll this out on a per-host basis 👍
csfrancis
approved these changes
Jul 4, 2019
Contributor
csfrancis
left a comment
csfrancis
left a comment
There was a problem hiding this comment.
This is so much nicer than the C implementation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR allows
SEMIAN_CIRCUIT_BREAKER_FORCE_HOSTto force-enable host-based circuits.Why
To deploy #227 on core, we want to enable host-based circuits on a single node, so we can observe their behaviour through a Rails console.
cc: @Shopify/servcomm