Exclude certain Bundler settings when composing bundle #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
andyw8
approved these changes
Mar 7, 2025
Merge activity
|
### Motivation Closes #2440, closes #3196 Certain Bundler settings are better used only when the user is in control, like deciding when to package gems or if Bundler should automatically install binstubs for all gems. This PR starts ignoring certain settings from the composed environment. ### Implementation Added a list of ignored settings that we reject before building the environment that we'll use to run bundle install/update. ### Automated Tests Added tests for both bundle bin and bundle package related settings.
graphite-app
bot
force-pushed
the
03-07-exclude_certain_bundler_settings_when_composing_bundle
branch
from
fbc65c7 to
81b238c
Compare
alexcrocha
approved these changes
Mar 7, 2025
Morriar
approved these changes
Mar 7, 2025
graphite-app
bot
deleted the
03-07-exclude_certain_bundler_settings_when_composing_bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2440, closes #3196
Certain Bundler settings are better used only when the user is in control, like deciding when to package gems or if Bundler should automatically install binstubs for all gems.
This PR starts ignoring certain settings from the composed environment.
Implementation
Added a list of ignored settings that we reject before building the environment that we'll use to run bundle install/update.
Automated Tests
Added tests for both bundle bin and bundle package related settings.